Re: [Mesa-dev] [PATCH 18.0 v2] i965, gallium: Disable ARB_get_program_binary for compat profiles

2018-02-23 Thread Scott D Phillips
Ilia Mirkin writes: > Jordan - terribly sorry I got you into this mess :( Just drop the > st/mesa hunk and push the i965 change - I believe that's all reviewed > and tested. The patch with just the i965 hunk is: Reviewed-by: Scott D Phillips ___ mesa

Re: [Mesa-dev] [PATCH 18.0 v2] i965, gallium: Disable ARB_get_program_binary for compat profiles

2018-02-23 Thread Ilia Mirkin
Jordan - terribly sorry I got you into this mess :( Just drop the st/mesa hunk and push the i965 change - I believe that's all reviewed and tested. Marek - feel free to rewrite it the way you suggest. This is something that'll get reverted later, so I didn't want to mess about with function signat

Re: [Mesa-dev] [PATCH 18.0 v2] i965, gallium: Disable ARB_get_program_binary for compat profiles

2018-02-23 Thread Marek Olšák
Please keep the extension exposed in GL compat. Eventually we want to expose all extensions in GL compat. st_init_limits is the proper place - please use that. While st_init_limits doesn't have the API parameter, both of its call sites have it, so it's just a matter of passing it to the function.

Re: [Mesa-dev] [PATCH 18.0 v2] i965, gallium: Disable ARB_get_program_binary for compat profiles

2018-02-22 Thread Ilia Mirkin
On Thu, Feb 22, 2018 at 7:41 PM, Ilia Mirkin wrote: > On Thu, Feb 22, 2018 at 7:39 PM, Emil Velikov > wrote: >> On 23 February 2018 at 00:17, Ilia Mirkin wrote: >>> On Thu, Feb 22, 2018 at 7:11 PM, Emil Velikov >>> wrote: > diff --git a/src/mesa/state_tracker/st_context.c > b/src/mes

Re: [Mesa-dev] [PATCH 18.0 v2] i965, gallium: Disable ARB_get_program_binary for compat profiles

2018-02-22 Thread Ilia Mirkin
On Thu, Feb 22, 2018 at 7:39 PM, Emil Velikov wrote: > On 23 February 2018 at 00:17, Ilia Mirkin wrote: >> On Thu, Feb 22, 2018 at 7:11 PM, Emil Velikov >> wrote: diff --git a/src/mesa/state_tracker/st_context.c b/src/mesa/state_tracker/st_context.c index d3e7d3fb7fa..4c14245a38

Re: [Mesa-dev] [PATCH 18.0 v2] i965, gallium: Disable ARB_get_program_binary for compat profiles

2018-02-22 Thread Emil Velikov
On 23 February 2018 at 00:17, Ilia Mirkin wrote: > On Thu, Feb 22, 2018 at 7:11 PM, Emil Velikov > wrote: >> Hi Jordan, >> >> On 22 February 2018 at 19:59, Jordan Justen >> wrote: >>> The QT framework has a bug in their shader program cache, which is >>> built on GL_ARB_get_program_binary. >>>

Re: [Mesa-dev] [PATCH 18.0 v2] i965, gallium: Disable ARB_get_program_binary for compat profiles

2018-02-22 Thread Ilia Mirkin
On Thu, Feb 22, 2018 at 7:11 PM, Emil Velikov wrote: > Hi Jordan, > > On 22 February 2018 at 19:59, Jordan Justen wrote: >> The QT framework has a bug in their shader program cache, which is >> built on GL_ARB_get_program_binary. >> >> In an effort to allow them to fix the bug we don't enable mor

Re: [Mesa-dev] [PATCH 18.0 v2] i965, gallium: Disable ARB_get_program_binary for compat profiles

2018-02-22 Thread Emil Velikov
Hi Jordan, On 22 February 2018 at 19:59, Jordan Justen wrote: > The QT framework has a bug in their shader program cache, which is > built on GL_ARB_get_program_binary. > > In an effort to allow them to fix the bug we don't enable more than 1 > binary format for compatibility profiles. > Doing Nu

Re: [Mesa-dev] [PATCH 18.0 v2] i965, gallium: Disable ARB_get_program_binary for compat profiles

2018-02-22 Thread Scott D Phillips
Jordan Justen writes: > The QT framework has a bug in their shader program cache, which is > built on GL_ARB_get_program_binary. > > In an effort to allow them to fix the bug we don't enable more than 1 > binary format for compatibility profiles. > > This is only being done on the 18.0 release br

[Mesa-dev] [PATCH 18.0 v2] i965, gallium: Disable ARB_get_program_binary for compat profiles

2018-02-22 Thread Jordan Justen
The QT framework has a bug in their shader program cache, which is built on GL_ARB_get_program_binary. In an effort to allow them to fix the bug we don't enable more than 1 binary format for compatibility profiles. This is only being done on the 18.0 release branch. Ref: https://bugreports.qt.io