Re: [Mesa-dev] [PATCH 2/2] anv, radv: Drop XML workarounds for VK_ANDROID_native_buffer

2018-04-16 Thread Dylan Baker 
Quoting Jason Ekstrand (2018-04-16 07:38:53)
> ---
>  src/amd/vulkan/radv_extensions.py  | 7 +--
>  src/intel/vulkan/anv_extensions_gen.py | 7 +--
>  2 files changed, 2 insertions(+), 12 deletions(-)
> 
> diff --git a/src/amd/vulkan/radv_extensions.py 
> b/src/amd/vulkan/radv_extensions.py
> index db37d61..099cae7 100644
> --- a/src/amd/vulkan/radv_extensions.py
> +++ b/src/amd/vulkan/radv_extensions.py
> @@ -161,12 +161,7 @@ def _init_exts_from_xml(xml):
>  continue
>  
>  ext = ext_name_map[ext_name]
> -if ext_name == 'VK_ANDROID_native_buffer':
> -# VK_ANDROID_native_buffer is missing the type specifier.  Just
> -# hard-code it to be a device extension for now.
> -ext.type = 'device'
> -else:
> -ext.type = ext_elem.attrib['type']
> +ext.type = ext_elem.attrib['type']
>  
>  _TEMPLATE_H = Template(COPYRIGHT + """
>  #ifndef RADV_EXTENSIONS_H
> diff --git a/src/intel/vulkan/anv_extensions_gen.py 
> b/src/intel/vulkan/anv_extensions_gen.py
> index 57a5285..5ea8220 100644
> --- a/src/intel/vulkan/anv_extensions_gen.py
> +++ b/src/intel/vulkan/anv_extensions_gen.py
> @@ -46,12 +46,7 @@ def _init_exts_from_xml(xml):
>  continue
>  
>  ext = ext_name_map[ext_name]
> -if ext_name == 'VK_ANDROID_native_buffer':
> -# VK_ANDROID_native_buffer is missing the type specifier.  Just
> -# hard-code it to be a device extension for now.
> -ext.type = 'device'
> -else:
> -ext.type = ext_elem.attrib['type']
> +ext.type = ext_elem.attrib['type']
>  
>  _TEMPLATE_H = Template(COPYRIGHT + """
>  
> -- 
> 2.5.0.400.gff86faf
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev

I have you an informal rb this morning in person,

Reviewed-by: Dylan Baker 


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] anv, radv: Drop XML workarounds for VK_ANDROID_native_buffer

2018-04-16 Thread Samuel Pitoiset 

Reviewed-by: Samuel Pitoiset 

On 04/16/2018 04:38 PM, Jason Ekstrand wrote:

---
  src/amd/vulkan/radv_extensions.py  | 7 +--
  src/intel/vulkan/anv_extensions_gen.py | 7 +--
  2 files changed, 2 insertions(+), 12 deletions(-)

diff --git a/src/amd/vulkan/radv_extensions.py 
b/src/amd/vulkan/radv_extensions.py
index db37d61..099cae7 100644
--- a/src/amd/vulkan/radv_extensions.py
+++ b/src/amd/vulkan/radv_extensions.py
@@ -161,12 +161,7 @@ def _init_exts_from_xml(xml):
  continue
  
  ext = ext_name_map[ext_name]

-if ext_name == 'VK_ANDROID_native_buffer':
-# VK_ANDROID_native_buffer is missing the type specifier.  Just
-# hard-code it to be a device extension for now.
-ext.type = 'device'
-else:
-ext.type = ext_elem.attrib['type']
+ext.type = ext_elem.attrib['type']
  
  _TEMPLATE_H = Template(COPYRIGHT + """

  #ifndef RADV_EXTENSIONS_H
diff --git a/src/intel/vulkan/anv_extensions_gen.py 
b/src/intel/vulkan/anv_extensions_gen.py
index 57a5285..5ea8220 100644
--- a/src/intel/vulkan/anv_extensions_gen.py
+++ b/src/intel/vulkan/anv_extensions_gen.py
@@ -46,12 +46,7 @@ def _init_exts_from_xml(xml):
  continue
  
  ext = ext_name_map[ext_name]

-if ext_name == 'VK_ANDROID_native_buffer':
-# VK_ANDROID_native_buffer is missing the type specifier.  Just
-# hard-code it to be a device extension for now.
-ext.type = 'device'
-else:
-ext.type = ext_elem.attrib['type']
+ext.type = ext_elem.attrib['type']
  
  _TEMPLATE_H = Template(COPYRIGHT + """
  


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/2] anv, radv: Drop XML workarounds for VK_ANDROID_native_buffer

2018-04-16 Thread Jason Ekstrand 
---
 src/amd/vulkan/radv_extensions.py  | 7 +--
 src/intel/vulkan/anv_extensions_gen.py | 7 +--
 2 files changed, 2 insertions(+), 12 deletions(-)

diff --git a/src/amd/vulkan/radv_extensions.py 
b/src/amd/vulkan/radv_extensions.py
index db37d61..099cae7 100644
--- a/src/amd/vulkan/radv_extensions.py
+++ b/src/amd/vulkan/radv_extensions.py
@@ -161,12 +161,7 @@ def _init_exts_from_xml(xml):
 continue
 
 ext = ext_name_map[ext_name]
-if ext_name == 'VK_ANDROID_native_buffer':
-# VK_ANDROID_native_buffer is missing the type specifier.  Just
-# hard-code it to be a device extension for now.
-ext.type = 'device'
-else:
-ext.type = ext_elem.attrib['type']
+ext.type = ext_elem.attrib['type']
 
 _TEMPLATE_H = Template(COPYRIGHT + """
 #ifndef RADV_EXTENSIONS_H
diff --git a/src/intel/vulkan/anv_extensions_gen.py 
b/src/intel/vulkan/anv_extensions_gen.py
index 57a5285..5ea8220 100644
--- a/src/intel/vulkan/anv_extensions_gen.py
+++ b/src/intel/vulkan/anv_extensions_gen.py
@@ -46,12 +46,7 @@ def _init_exts_from_xml(xml):
 continue
 
 ext = ext_name_map[ext_name]
-if ext_name == 'VK_ANDROID_native_buffer':
-# VK_ANDROID_native_buffer is missing the type specifier.  Just
-# hard-code it to be a device extension for now.
-ext.type = 'device'
-else:
-ext.type = ext_elem.attrib['type']
+ext.type = ext_elem.attrib['type']
 
 _TEMPLATE_H = Template(COPYRIGHT + """
 
-- 
2.5.0.400.gff86faf

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev