Re: [Mesa-dev] [PATCH 2/2] swr: Remove unneeeded comparison

2017-09-26 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak  

> On Sep 25, 2017, at 5:28 PM, George Kyriazis  
> wrote:
> 
> No need to check if screen->pipe != pipe, so we can just assign it.  Just do 
> it.
> ---
> src/gallium/drivers/swr/swr_state.cpp | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/gallium/drivers/swr/swr_state.cpp 
> b/src/gallium/drivers/swr/swr_state.cpp
> index 893bd6e..c6da4fc 100644
> --- a/src/gallium/drivers/swr/swr_state.cpp
> +++ b/src/gallium/drivers/swr/swr_state.cpp
> @@ -1074,8 +1074,7 @@ swr_update_derived(struct pipe_context *pipe,
>}
> 
>/* Update screen->pipe to current pipe context. */
> -   if (screen->pipe != pipe)
> -  screen->pipe = pipe;
> +   screen->pipe = pipe;
> 
>/* Any state that requires dirty flags to be re-triggered sets this mask */
>/* For example, user_buffer vertex and index buffers. */
> -- 
> 2.7.4
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH 2/2] swr: Remove unneeeded comparison

2017-09-25 Thread George Kyriazis
No need to check if screen->pipe != pipe, so we can just assign it.  Just do it.
---
 src/gallium/drivers/swr/swr_state.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/gallium/drivers/swr/swr_state.cpp 
b/src/gallium/drivers/swr/swr_state.cpp
index 893bd6e..c6da4fc 100644
--- a/src/gallium/drivers/swr/swr_state.cpp
+++ b/src/gallium/drivers/swr/swr_state.cpp
@@ -1074,8 +1074,7 @@ swr_update_derived(struct pipe_context *pipe,
}
 
/* Update screen->pipe to current pipe context. */
-   if (screen->pipe != pipe)
-  screen->pipe = pipe;
+   screen->pipe = pipe;
 
/* Any state that requires dirty flags to be re-triggered sets this mask */
/* For example, user_buffer vertex and index buffers. */
-- 
2.7.4

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev