Re: [Mesa-dev] [PATCH 3/3] ac: make use of if/loop build helpers

On 10 April 2018 at 15:49, Juan A. Suarez Romero wrote: > On Tue, 2018-04-03 at 10:58 +0100, Alex Smith wrote: > > I don't know exactly what's causing it, no. I noticed the issue was > fixed on master so just bisected to this. > > > > CC'ing stable to nominate: > >

Re: [Mesa-dev] [PATCH 3/3] ac: make use of if/loop build helpers

On Tue, 2018-04-03 at 10:58 +0100, Alex Smith wrote: > I don't know exactly what's causing it, no. I noticed the issue was fixed on > master so just bisected to this. > > CC'ing stable to nominate: > 42627dabb4db3011825a022325be7ae9b51103d6 - (1/3) ac: add if/loop build > helpers >

Re: [Mesa-dev] [PATCH 3/3] ac: make use of if/loop build helpers

I don't know exactly what's causing it, no. I noticed the issue was fixed on master so just bisected to this. CC'ing stable to nominate: 42627dabb4db3011825a022325be7ae9b51103d6 - (1/3) ac: add if/loop build helpers 6e1a142863b368a032e333f09feb107241446053 - (2/3) radeonsi: make use of if/loop

Re: [Mesa-dev] [PATCH 3/3] ac: make use of if/loop build helpers

I have no issue with these going in stable if they fix bugs. Ideally we should create a piglit test to catch this also but presumably you guys don't actually know the exact shader combination thats tripping things up? On 03/04/18 19:36, Samuel Pitoiset wrote: This fixes a rendering issue with

Re: [Mesa-dev] [PATCH 3/3] ac: make use of if/loop build helpers

This fixes a rendering issue with Wolfenstein 2 as well. A backport sounds reasonable to me. On 04/03/2018 11:33 AM, Alex Smith wrote: Hi Timothy, This patch fixes some rendering issues I see with RADV on SI. It doesn't sound like it was really intended to fix anything, so possibly it's

Re: [Mesa-dev] [PATCH 3/3] ac: make use of if/loop build helpers

Hi Timothy, This patch fixes some rendering issues I see with RADV on SI. It doesn't sound like it was really intended to fix anything, so possibly it's masking some other issue, but would you object to nominating the series for stable? Applying it on the 18.0 branch fixes the issue there as

Re: [Mesa-dev] [PATCH 3/3] ac: make use of if/loop build helpers

For the series: Reviewed-by: Marek Olšák Marek On Tue, Mar 6, 2018 at 8:40 PM, Timothy Arceri wrote: > These helpers insert the basic block in the same order as they > appear in NIR making it easier to follow LLVM IR dumps. The helpers > also insert

[Mesa-dev] [PATCH 3/3] ac: make use of if/loop build helpers

These helpers insert the basic block in the same order as they appear in NIR making it easier to follow LLVM IR dumps. The helpers also insert more useful labels onto the blocks. TGSI use the line number of the corresponding opcode in the TGSI dump as the label id, here we use the corresponding