Re: [Mesa-dev] [PATCH 4/5] radv: move AMDGPU_LIBS later in the link chain

2016-10-12 Thread Edward O'Callaghan 
Reviewed-by: Edward O'Callaghan 

On 10/13/2016 05:05 AM, Emil Velikov wrote:
> From: Emil Velikov 
> 
> At the moment (albeit unlikely) one could get link-time issues, since
> libdrm_amdgpu.so is before it's users in the link chain.
> 
> Signed-off-by: Emil Velikov 
> ---
> As a nice bonus the diff vs the anv Makefile is quite small now ;-)
> ---
>  src/amd/vulkan/Makefile.am | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/amd/vulkan/Makefile.am b/src/amd/vulkan/Makefile.am
> index b6f3d00..e2f5c02 100644
> --- a/src/amd/vulkan/Makefile.am
> +++ b/src/amd/vulkan/Makefile.am
> @@ -58,7 +58,7 @@ VULKAN_SOURCES = \
>   $(VULKAN_GENERATED_FILES) \
>   $(VULKAN_FILES)
>  
> -VULKAN_LIB_DEPS = $(AMDGPU_LIBS)
> +VULKAN_LIB_DEPS =
>  
>  
>  if HAVE_PLATFORM_X11
> @@ -100,6 +100,7 @@ VULKAN_LIB_DEPS += \
>   $(LLVM_LIBS) \
>   $(LIBELF_LIBS) \
>   $(PTHREAD_LIBS) \
> + $(AMDGPU_LIBS) \
>   $(LIBDRM_LIBS) \
>   $(PTHREAD_LIBS) \
>   $(DLOPEN_LIBS) \
> 



signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 4/5] radv: move AMDGPU_LIBS later in the link chain

2016-10-12 Thread Dave Airlie 
>
> At the moment (albeit unlikely) one could get link-time issues, since
> libdrm_amdgpu.so is before it's users in the link chain.
>
> Signed-off-by: Emil Velikov 

Reviewed-by: Dave Airlie 
> ---
> As a nice bonus the diff vs the anv Makefile is quite small now ;-)
> ---
>  src/amd/vulkan/Makefile.am | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/Makefile.am b/src/amd/vulkan/Makefile.am
> index b6f3d00..e2f5c02 100644
> --- a/src/amd/vulkan/Makefile.am
> +++ b/src/amd/vulkan/Makefile.am
> @@ -58,7 +58,7 @@ VULKAN_SOURCES = \
> $(VULKAN_GENERATED_FILES) \
> $(VULKAN_FILES)
>
> -VULKAN_LIB_DEPS = $(AMDGPU_LIBS)
> +VULKAN_LIB_DEPS =
>
>
>  if HAVE_PLATFORM_X11
> @@ -100,6 +100,7 @@ VULKAN_LIB_DEPS += \
> $(LLVM_LIBS) \
> $(LIBELF_LIBS) \
> $(PTHREAD_LIBS) \
> +   $(AMDGPU_LIBS) \
> $(LIBDRM_LIBS) \
> $(PTHREAD_LIBS) \
> $(DLOPEN_LIBS) \
> --
> 2.10.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 4/5] radv: move AMDGPU_LIBS later in the link chain

2016-10-12 Thread Emil Velikov 
From: Emil Velikov 

At the moment (albeit unlikely) one could get link-time issues, since
libdrm_amdgpu.so is before it's users in the link chain.

Signed-off-by: Emil Velikov 
---
As a nice bonus the diff vs the anv Makefile is quite small now ;-)
---
 src/amd/vulkan/Makefile.am | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/amd/vulkan/Makefile.am b/src/amd/vulkan/Makefile.am
index b6f3d00..e2f5c02 100644
--- a/src/amd/vulkan/Makefile.am
+++ b/src/amd/vulkan/Makefile.am
@@ -58,7 +58,7 @@ VULKAN_SOURCES = \
$(VULKAN_GENERATED_FILES) \
$(VULKAN_FILES)
 
-VULKAN_LIB_DEPS = $(AMDGPU_LIBS)
+VULKAN_LIB_DEPS =
 
 
 if HAVE_PLATFORM_X11
@@ -100,6 +100,7 @@ VULKAN_LIB_DEPS += \
$(LLVM_LIBS) \
$(LIBELF_LIBS) \
$(PTHREAD_LIBS) \
+   $(AMDGPU_LIBS) \
$(LIBDRM_LIBS) \
$(PTHREAD_LIBS) \
$(DLOPEN_LIBS) \
-- 
2.10.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev