Re: [Mesa-dev] [PATCH 5/5] ac: use correct LLVM opcodes for ordered comparisons

2018-02-23 Thread Marek Olšák
On Fri, Feb 23, 2018 at 8:18 PM, Bas Nieuwenhuizen wrote: > On Fri, Feb 23, 2018 at 6:39 PM, Connor Abbott wrote: >> On Fri, Feb 23, 2018 at 8:30 AM, Bas Nieuwenhuizen >> wrote: >>> >>> >>> On Thu, Feb 15, 2018 at 8:54 AM,

Re: [Mesa-dev] [PATCH 5/5] ac: use correct LLVM opcodes for ordered comparisons

2018-02-23 Thread Bas Nieuwenhuizen
On Fri, Feb 23, 2018 at 6:39 PM, Connor Abbott wrote: > On Fri, Feb 23, 2018 at 8:30 AM, Bas Nieuwenhuizen wrote: >> >> >> On Thu, Feb 15, 2018 at 8:54 AM, Connor Abbott wrote: >>> >>> On Wed, Feb 14, 2018 at 11:53 PM, Timothy Arceri

Re: [Mesa-dev] [PATCH 5/5] ac: use correct LLVM opcodes for ordered comparisons

2018-02-23 Thread Marek Olšák
On Fri, Feb 23, 2018 at 6:39 PM, Connor Abbott wrote: > On Fri, Feb 23, 2018 at 8:30 AM, Bas Nieuwenhuizen wrote: >> >> >> On Thu, Feb 15, 2018 at 8:54 AM, Connor Abbott wrote: >>> >>> On Wed, Feb 14, 2018 at 11:53 PM, Timothy Arceri

Re: [Mesa-dev] [PATCH 5/5] ac: use correct LLVM opcodes for ordered comparisons

2018-02-23 Thread Connor Abbott
On Fri, Feb 23, 2018 at 8:30 AM, Bas Nieuwenhuizen wrote: > > > On Thu, Feb 15, 2018 at 8:54 AM, Connor Abbott wrote: >> >> On Wed, Feb 14, 2018 at 11:53 PM, Timothy Arceri >> wrote: >> > >> > >> > On 15/02/18 04:39, Marek Olšák

Re: [Mesa-dev] [PATCH 5/5] ac: use correct LLVM opcodes for ordered comparisons

2018-02-23 Thread Bas Nieuwenhuizen
On Thu, Feb 15, 2018 at 8:54 AM, Connor Abbott wrote: > On Wed, Feb 14, 2018 at 11:53 PM, Timothy Arceri > wrote: > > > > > > On 15/02/18 04:39, Marek Olšák wrote: > >> > >> Reviewed-by: Marek Olšák > >> > >> Marek > >> > >> On

Re: [Mesa-dev] [PATCH 5/5] ac: use correct LLVM opcodes for ordered comparisons

2018-02-15 Thread Timothy Arceri
On 15/02/18 20:06, Bas Nieuwenhuizen wrote: On Thu, Feb 15, 2018 at 8:54 AM, Connor Abbott wrote: On Wed, Feb 14, 2018 at 11:53 PM, Timothy Arceri wrote: On 15/02/18 04:39, Marek Olšák wrote: Reviewed-by: Marek Olšák

Re: [Mesa-dev] [PATCH 5/5] ac: use correct LLVM opcodes for ordered comparisons

2018-02-15 Thread Bas Nieuwenhuizen
On Thu, Feb 15, 2018 at 8:54 AM, Connor Abbott wrote: > On Wed, Feb 14, 2018 at 11:53 PM, Timothy Arceri > wrote: >> >> >> On 15/02/18 04:39, Marek Olšák wrote: >>> >>> Reviewed-by: Marek Olšák >>> >>> Marek >>> >>> On Wed, Feb

Re: [Mesa-dev] [PATCH 5/5] ac: use correct LLVM opcodes for ordered comparisons

2018-02-14 Thread Connor Abbott
On Wed, Feb 14, 2018 at 11:53 PM, Timothy Arceri wrote: > > > On 15/02/18 04:39, Marek Olšák wrote: >> >> Reviewed-by: Marek Olšák >> >> Marek >> >> On Wed, Feb 14, 2018 at 7:29 AM, Timothy Arceri >> wrote: >>> >>> Fixes

Re: [Mesa-dev] [PATCH 5/5] ac: use correct LLVM opcodes for ordered comparisons

2018-02-14 Thread Timothy Arceri
On 15/02/18 04:39, Marek Olšák wrote: Reviewed-by: Marek Olšák Marek On Wed, Feb 14, 2018 at 7:29 AM, Timothy Arceri wrote: Fixes glsl-1.30/execution/isinf-and-isnan* piglit tests for radeonsi and should fix SPIRV errors when LLVM optimises away

Re: [Mesa-dev] [PATCH 5/5] ac: use correct LLVM opcodes for ordered comparisons

2018-02-14 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Feb 14, 2018 at 7:29 AM, Timothy Arceri wrote: > Fixes glsl-1.30/execution/isinf-and-isnan* piglit tests for > radeonsi and should fix SPIRV errors when LLVM optimises away > the workarounds in vtn_handle_alu()

[Mesa-dev] [PATCH 5/5] ac: use correct LLVM opcodes for ordered comparisons

2018-02-13 Thread Timothy Arceri
Fixes glsl-1.30/execution/isinf-and-isnan* piglit tests for radeonsi and should fix SPIRV errors when LLVM optimises away the workarounds in vtn_handle_alu() for handling ordered comparisons. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104905 --- src/amd/common/ac_nir_to_llvm.c | 8