Re: [Mesa-dev] [PATCH 5/8] glsl: clone builtin function constants

2017-08-09 Thread Kenneth Graunke
On Tuesday, August 8, 2017 8:34:06 PM PDT Timothy Arceri wrote: > f81ede469910d fixed a problem with shaders including IR that was > owned by builtins. However the approach of cloning the whole > function each time we referenced it lead to a significant > reduction in the GLSL IR compiler performan

[Mesa-dev] [PATCH 5/8] glsl: clone builtin function constants

2017-08-08 Thread Timothy Arceri
f81ede469910d fixed a problem with shaders including IR that was owned by builtins. However the approach of cloning the whole function each time we referenced it lead to a significant reduction in the GLSL IR compiler performance. Everything was already cloned when inlining the function, as far as

[Mesa-dev] [PATCH 5/8] glsl: clone builtin function constants

2017-08-06 Thread Timothy Arceri
f81ede469910d fixed a problem with shaders including IR that was owned by builtins. However the approach of cloning the whole function each time we referenced it lead to a significant reduction in the GLSL IR compiler performance. Everything was already cloned when inlining the function, as far as