Re: [Mesa-dev] [PATCH 6/7] spirv/i965/anv: Relax push constant offset assertions being 32-bit aligned (v2)

2018-02-26 Thread Jason Ekstrand
On Mon, Feb 26, 2018 at 6:01 AM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > The introduction of 16-bit types with VK_KHR_16bit_storages implies that > push constant offsets could be multiple of 2-bytes. Some assertions are > updated so offsets should be just multiple of size of t

[Mesa-dev] [PATCH 6/7] spirv/i965/anv: Relax push constant offset assertions being 32-bit aligned (v2)

2018-02-26 Thread Jose Maria Casanova Crespo
The introduction of 16-bit types with VK_KHR_16bit_storages implies that push constant offsets could be multiple of 2-bytes. Some assertions are updated so offsets should be just multiple of size of the base type but in some cases we can not assume it as doubles aren't aligned to 8 bytes in some ca

Re: [Mesa-dev] [PATCH 6/7] spirv/i965/anv: Relax push constant offset assertions being 32-bit aligned

2018-02-26 Thread Chema Casanova
El 23/02/18 a las 22:36, Jason Ekstrand escribió: > Assuming the CTS is still happy with it after those changes, CTS was happy, but piglit has complained a lot. > > Reviewed-by: Jason Ekstrand > > > On Fri, Feb 23, 2018 at 1:16 PM, Chema Casanova

Re: [Mesa-dev] [PATCH 6/7] spirv/i965/anv: Relax push constant offset assertions being 32-bit aligned

2018-02-23 Thread Jason Ekstrand
Assuming the CTS is still happy with it after those changes, Reviewed-by: Jason Ekstrand On Fri, Feb 23, 2018 at 1:16 PM, Chema Casanova wrote: > On 23/02/18 20:09, Jason Ekstrand wrote: > > On Fri, Feb 23, 2018 at 1:26 AM, Jose Maria Casanova Crespo > > mailto:jmcasan...@igalia.com>> wrote: >

Re: [Mesa-dev] [PATCH 6/7] spirv/i965/anv: Relax push constant offset assertions being 32-bit aligned

2018-02-23 Thread Chema Casanova
On 23/02/18 20:09, Jason Ekstrand wrote: > On Fri, Feb 23, 2018 at 1:26 AM, Jose Maria Casanova Crespo > mailto:jmcasan...@igalia.com>> wrote: > > The introduction of 16-bit types with VK_KHR_16bit_storages implies that > push constant offsets could be multiple of 2-bytes. Some assertions

Re: [Mesa-dev] [PATCH 6/7] spirv/i965/anv: Relax push constant offset assertions being 32-bit aligned

2018-02-23 Thread Jason Ekstrand
On Fri, Feb 23, 2018 at 1:26 AM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > The introduction of 16-bit types with VK_KHR_16bit_storages implies that > push constant offsets could be multiple of 2-bytes. Some assertions are > relaxed so offsets can be multiple of 4-bytes or multip

[Mesa-dev] [PATCH 6/7] spirv/i965/anv: Relax push constant offset assertions being 32-bit aligned

2018-02-23 Thread Jose Maria Casanova Crespo
The introduction of 16-bit types with VK_KHR_16bit_storages implies that push constant offsets could be multiple of 2-bytes. Some assertions are relaxed so offsets can be multiple of 4-bytes or multiple of size of the base type. For 16-bit types, the push constant offset takes into account the int