Re: [Mesa-dev] [PATCH 6/9] autotools: error out when building with mangling and glvnd

2018-02-23 Thread Dylan Baker
Quoting Emil Velikov (2018-02-23 11:32:05)
> From: Emil Velikov 
> 
> It's not a thing that can work, nor is a wise idea to attempt.
> 
> Signed-off-by: Emil Velikov 
> ---
>  configure.ac | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/configure.ac b/configure.ac
> index d56d771dcd6..1e794d3f16d 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1501,6 +1501,9 @@ AC_ARG_ENABLE([mangling],
>[enable_mangling=no]
>  )
>  if test "x${enable_mangling}" = "xyes" ; then
> +  if test "x$enable_libglvnd" = xyes; then
> +AC_MSG_ERROR([Building --enable-mangling with --enable-libglvnd no 
> allowed.])

The grammar is a bit off in this "no" should be "is not",
but how about:
`Conflicting options --enable-mangling and --enable-libglvnd`?

Dylan

> +  fi
>DEFINES="${DEFINES} -DUSE_MGL_NAMESPACE"
>GL_LIB="Mangled${GL_LIB}"
>OSMESA_LIB="Mangled${OSMESA_LIB}"
> -- 
> 2.16.0
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH 6/9] autotools: error out when building with mangling and glvnd

2018-02-23 Thread Emil Velikov
From: Emil Velikov 

It's not a thing that can work, nor is a wise idea to attempt.

Signed-off-by: Emil Velikov 
---
 configure.ac | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/configure.ac b/configure.ac
index d56d771dcd6..1e794d3f16d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1501,6 +1501,9 @@ AC_ARG_ENABLE([mangling],
   [enable_mangling=no]
 )
 if test "x${enable_mangling}" = "xyes" ; then
+  if test "x$enable_libglvnd" = xyes; then
+AC_MSG_ERROR([Building --enable-mangling with --enable-libglvnd no 
allowed.])
+  fi
   DEFINES="${DEFINES} -DUSE_MGL_NAMESPACE"
   GL_LIB="Mangled${GL_LIB}"
   OSMESA_LIB="Mangled${OSMESA_LIB}"
-- 
2.16.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev