Re: [Mesa-dev] [PATCH v2] nir: Get rid of nir_constant_data

2016-12-01 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Thu, 2016-12-01 at 16:07 -0800, Jason Ekstrand wrote: > This has bothered me for about as long as NIR has been around.  Why > do we > have two different unions for constants?  No good reason other than > one of > them is a direct port from GLSL IR. > --- >  src/

[Mesa-dev] [PATCH v2] nir: Get rid of nir_constant_data

2016-12-01 Thread Jason Ekstrand
This has bothered me for about as long as NIR has been around. Why do we have two different unions for constants? No good reason other than one of them is a direct port from GLSL IR. --- src/compiler/glsl/glsl_to_nir.cpp | 35 +--- src/compiler/nir/nir.c | 32 +++