Re: [Mesa-dev] [PATCH v2 16/32] i965: Don't rely on nir for uses_texture_gather

2017-10-19 Thread Timothy Arceri
On 20/10/17 09:38, Jordan Justen wrote: On 2017-10-19 15:07:45, Timothy Arceri wrote: Maybe you should just do: prog->nir->info = prog->info; After you restore nir from the cache? We only deserialize from nir if the gen program restore fails. So, hopefully prog->nir will be NULL. IMO we

Re: [Mesa-dev] [PATCH v2 16/32] i965: Don't rely on nir for uses_texture_gather

2017-10-19 Thread Jordan Justen
On 2017-10-19 15:07:45, Timothy Arceri wrote: > Maybe you should just do: > > prog->nir->info = prog->info; > > After you restore nir from the cache? We only deserialize from nir if the gen program restore fails. So, hopefully prog->nir will be NULL. -Jordan > > On 19/10/17 16:32, Jordan

Re: [Mesa-dev] [PATCH v2 16/32] i965: Don't rely on nir for uses_texture_gather

2017-10-19 Thread Timothy Arceri
Maybe you should just do: prog->nir->info = prog->info; After you restore nir from the cache? On 19/10/17 16:32, Jordan Justen wrote: When a program is restored from the shader cache, prog->nir will be NULL, but prog->info will be restored. Signed-off-by: Jordan Justen

[Mesa-dev] [PATCH v2 16/32] i965: Don't rely on nir for uses_texture_gather

2017-10-18 Thread Jordan Justen
When a program is restored from the shader cache, prog->nir will be NULL, but prog->info will be restored. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_wm.c | 4 ++-- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 12 ++--