Re: [Mesa-dev] [PATCH v2 18/32] i965: add initial implementation of on disk shader cache

I've got a meta-comment and then a couple more inline comments below before I sign-off for the week-end. Most of my comments on this patch have focussed towards two goals: 1) As close to perfect paridy between read_program_data and write_program_data as we can manage. They should be almost

Re: [Mesa-dev] [PATCH v2 18/32] i965: add initial implementation of on disk shader cache

On Fri, Oct 20, 2017 at 4:05 PM, Jason Ekstrand wrote: > On Wed, Oct 18, 2017 at 10:32 PM, Jordan Justen > wrote: > >> From: Timothy Arceri >> >> This uses the recently-added disk_cache.c to write out the final >>

Re: [Mesa-dev] [PATCH v2 18/32] i965: add initial implementation of on disk shader cache

On Wed, Oct 18, 2017 at 10:32 PM, Jordan Justen wrote: > From: Timothy Arceri > > This uses the recently-added disk_cache.c to write out the final > linked binary for vertex and fragment shader programs. > > This is based off the initial

[Mesa-dev] [PATCH v2 18/32] i965: add initial implementation of on disk shader cache

From: Timothy Arceri This uses the recently-added disk_cache.c to write out the final linked binary for vertex and fragment shader programs. This is based off the initial implementation done by Carl Worth. v2: * Squash 'i965: add image param shader cache support'