Re: [Mesa-dev] [PATCH v2 5/8] glsl: pass mem_ctx to constant_expression_value(...) and friends

2017-08-10 Thread Kenneth Graunke
On Thursday, August 10, 2017 3:42:29 AM PDT Timothy Arceri wrote: > The main motivation for this is that threaded compilation can fall > over if we were to allocate IR inside constant_expression_value() > when calling it on a builtin. This is because builtins are shared > across the whole OpenGL

[Mesa-dev] [PATCH v2 5/8] glsl: pass mem_ctx to constant_expression_value(...) and friends

2017-08-10 Thread Timothy Arceri
The main motivation for this is that threaded compilation can fall over if we were to allocate IR inside constant_expression_value() when calling it on a builtin. This is because builtins are shared across the whole OpenGL context. f81ede469910d worked around the problem by cloning the entire