Re: [Mesa-dev] [PATCH v3 05/13] mesa/st: Add helper classes for array merging and interleaving

On 01.05.2018 17:46, Gert Wollny wrote: Am Dienstag, den 01.05.2018, 12:38 +0200 schrieb Nicolai Hähnle: First some high-level remarks: Why is `finalized` necessary? The `finalize` operation should be idempotent, i.e. if you call if twice in a row, the second time should be a no-op. It

Re: [Mesa-dev] [PATCH v3 05/13] mesa/st: Add helper classes for array merging and interleaving

Am Dienstag, den 01.05.2018, 12:38 +0200 schrieb Nicolai Hähnle: > First some high-level remarks: > > Why is `finalized` necessary? The `finalize` operation should be > idempotent, i.e. if you call if twice in a row, the second time > should be a no-op. It actually works exactly like this. >

Re: [Mesa-dev] [PATCH v3 05/13] mesa/st: Add helper classes for array merging and interleaving

First some high-level remarks: Why is `finalized` necessary? The `finalize` operation should be idempotent, i.e. if you call if twice in a row, the second time should be a no-op. So you can just call finalize on the target array unconditionally. That would make the code cleaner. Similarly,

[Mesa-dev] [PATCH v3 05/13] mesa/st: Add helper classes for array merging and interleaving

Signed-off-by: Gert Wollny --- src/mesa/Makefile.sources | 2 + src/mesa/meson.build | 2 + .../state_tracker/st_glsl_to_tgsi_array_merge.cpp | 283 +