Re: [Mesa-dev] [PATCH v3 7/9] i965: Add and use a getter for the clear color

2018-04-23 Thread Jason Ekstrand
I don't really like the helper because it seems like there should be a simpler way to do this. That said, I don't know of one. :-) Reviewed-by: Jason Ekstrand On Wed, Apr 11, 2018 at 1:42 PM, Nanley Chery wrote: > This getter allows CNL to sample from fast-cleared sRGB textures correctly. > -

Re: [Mesa-dev] [PATCH v3 7/9] i965: Add and use a getter for the clear color

2018-04-23 Thread Nanley Chery
On Fri, Apr 20, 2018 at 03:18:18PM -0700, Rafael Antognolli wrote: > On Fri, Apr 20, 2018 at 03:01:44PM -0700, Nanley Chery wrote: > > On Fri, Apr 20, 2018 at 01:35:39PM -0700, Rafael Antognolli wrote: > > > On Wed, Apr 11, 2018 at 01:42:24PM -0700, Nanley Chery wrote: > > > > This getter allows CN

Re: [Mesa-dev] [PATCH v3 7/9] i965: Add and use a getter for the clear color

2018-04-20 Thread Rafael Antognolli
On Fri, Apr 20, 2018 at 03:01:44PM -0700, Nanley Chery wrote: > On Fri, Apr 20, 2018 at 01:35:39PM -0700, Rafael Antognolli wrote: > > On Wed, Apr 11, 2018 at 01:42:24PM -0700, Nanley Chery wrote: > > > This getter allows CNL to sample from fast-cleared sRGB textures > > > correctly. > > > > I th

Re: [Mesa-dev] [PATCH v3 7/9] i965: Add and use a getter for the clear color

2018-04-20 Thread Nanley Chery
On Fri, Apr 20, 2018 at 01:35:39PM -0700, Rafael Antognolli wrote: > On Wed, Apr 11, 2018 at 01:42:24PM -0700, Nanley Chery wrote: > > This getter allows CNL to sample from fast-cleared sRGB textures correctly. > > I think it might be worth mentioning in the commit message that the > helper both r

Re: [Mesa-dev] [PATCH v3 7/9] i965: Add and use a getter for the clear color

2018-04-20 Thread Rafael Antognolli
On Wed, Apr 11, 2018 at 01:42:24PM -0700, Nanley Chery wrote: > This getter allows CNL to sample from fast-cleared sRGB textures correctly. I think it might be worth mentioning in the commit message that the helper both returns the clear color for inline use, and updates the pointer to the indirec

[Mesa-dev] [PATCH v3 7/9] i965: Add and use a getter for the clear color

2018-04-11 Thread Nanley Chery
This getter allows CNL to sample from fast-cleared sRGB textures correctly. --- src/mesa/drivers/dri/i965/brw_blorp.c| 13 --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 7 +++--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c| 29 src/mesa/