Re: [Mesa-dev] anv/radv: WSI sharing code

[Jason Ekstrand]

I've dug through the whole thing now.  I'm not a fan of patch 21 (re-order
UNORM and sRGB) and gave detailed comments on it.  The rest are

Reviewed-by: Jason Ekstrand 

My only other real comment is that I think I'd rather we put a bit more
stuff in wsi_device so we're not passing so much around.  In particular,
the allocation functions and format functions could go there and maybe an
alloc.  If you wanted to clean that up as a follow-on patch, that's fine,
but I would like it cleaned up if you don't mind.

--Jason

On Sun, Oct 16, 2016 at 9:24 PM, Dave Airlie  wrote:

> This series builds on top of the previous sharing patches I sent.
>
> The aim here is to share the X11 and wayland WSI code between
> the two vulkan drivers so we have a consistent implementation and
> one place to fix bugs.
>
> The series modifies the anv code in place until it's suitable
> for sharing, then it moves it to shared directory, and ports
> radv to use it.
>
> The final code leaves the WSI APIs in the drivers, but they
> call directly into the shared code once they shed their driver
> specific structs, and pick a pAllocator.
>
> Dave.
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] anv/radv: WSI sharing code

[Edward O'Callaghan]

Reviewed-by: Edward O'Callaghan 

On 10/17/2016 03:24 PM, Dave Airlie wrote:
> This series builds on top of the previous sharing patches I sent.
> 
> The aim here is to share the X11 and wayland WSI code between
> the two vulkan drivers so we have a consistent implementation and
> one place to fix bugs.
> 
> The series modifies the anv code in place until it's suitable
> for sharing, then it moves it to shared directory, and ports
> radv to use it.
> 
> The final code leaves the WSI APIs in the drivers, but they
> call directly into the shared code once they shed their driver
> specific structs, and pick a pAllocator.
> 
> Dave.
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 



signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] anv/radv: WSI sharing code

[Dave Airlie]

This series builds on top of the previous sharing patches I sent.

The aim here is to share the X11 and wayland WSI code between
the two vulkan drivers so we have a consistent implementation and
one place to fix bugs.

The series modifies the anv code in place until it's suitable
for sharing, then it moves it to shared directory, and ports
radv to use it.

The final code leaves the WSI APIs in the drivers, but they
call directly into the shared code once they shed their driver
specific structs, and pick a pAllocator.

Dave.

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev