Re: [Mesa-dev] [PATCH] anv/entrypoints: VkGetDeviceProcAddr returns NULL for core instance commands

2018-03-07 Thread Emil Velikov
On 7 March 2018 at 08:02, Iago Toral wrote: > I just noticed that I had missed on of your comments: > > On Mon, 2018-03-05 at 12:11 +, Emil Velikov wrote: > (...) >> >> > EntrypointParam = namedtuple('EntrypointParam', 'type name decl') >> > >> > +DeviceChildrenList =

Re: [Mesa-dev] [PATCH] anv/entrypoints: VkGetDeviceProcAddr returns NULL for core instance commands

2018-03-07 Thread Iago Toral
I just noticed that I had missed on of your comments: On Mon, 2018-03-05 at 12:11 +, Emil Velikov wrote: (...) > > > EntrypointParam = namedtuple('EntrypointParam', 'type name decl') > > > > +DeviceChildrenList = ['VkDevice', 'VkQueue', 'VkCommandBuffer' ] > > + > > +def

Re: [Mesa-dev] [PATCH] anv/entrypoints: VkGetDeviceProcAddr returns NULL for core instance commands

2018-03-06 Thread Iago Toral
On Tue, 2018-03-06 at 14:17 +0100, Iago Toral wrote: > On Tue, 2018-03-06 at 13:05 +, Emil Velikov wrote: > > On 6 March 2018 at 12:26, Iago Toral wrote: > > > On Tue, 2018-03-06 at 12:16 +, Emil Velikov wrote: > > > > On 6 March 2018 at 12:09, Iago Toral

Re: [Mesa-dev] [PATCH] anv/entrypoints: VkGetDeviceProcAddr returns NULL for core instance commands

2018-03-06 Thread Iago Toral
On Tue, 2018-03-06 at 13:05 +, Emil Velikov wrote: > On 6 March 2018 at 12:26, Iago Toral wrote: > > On Tue, 2018-03-06 at 12:16 +, Emil Velikov wrote: > > > On 6 March 2018 at 12:09, Iago Toral wrote: > > > > On Tue, 2018-03-06 at 11:21 +, Emil

Re: [Mesa-dev] [PATCH] anv/entrypoints: VkGetDeviceProcAddr returns NULL for core instance commands

2018-03-06 Thread Emil Velikov
On 6 March 2018 at 12:26, Iago Toral wrote: > On Tue, 2018-03-06 at 12:16 +, Emil Velikov wrote: >> On 6 March 2018 at 12:09, Iago Toral wrote: >> > On Tue, 2018-03-06 at 11:21 +, Emil Velikov wrote: >> > > On 6 March 2018 at 09:57, Bas Nieuwenhuizen

Re: [Mesa-dev] [PATCH] anv/entrypoints: VkGetDeviceProcAddr returns NULL for core instance commands

2018-03-06 Thread Iago Toral
On Tue, 2018-03-06 at 12:16 +, Emil Velikov wrote: > On 6 March 2018 at 12:09, Iago Toral wrote: > > On Tue, 2018-03-06 at 11:21 +, Emil Velikov wrote: > > > On 6 March 2018 at 09:57, Bas Nieuwenhuizen > > > wrote: > > > > > > > > > > > > On Tue,

Re: [Mesa-dev] [PATCH] anv/entrypoints: VkGetDeviceProcAddr returns NULL for core instance commands

2018-03-06 Thread Emil Velikov
On 6 March 2018 at 12:09, Iago Toral wrote: > On Tue, 2018-03-06 at 11:21 +, Emil Velikov wrote: >> On 6 March 2018 at 09:57, Bas Nieuwenhuizen >> wrote: >> > >> > >> > On Tue, Mar 6, 2018 at 8:02 AM, Iago Toral >> > wrote: >> > > >>

Re: [Mesa-dev] [PATCH] anv/entrypoints: VkGetDeviceProcAddr returns NULL for core instance commands

2018-03-06 Thread Iago Toral
On Tue, 2018-03-06 at 11:21 +, Emil Velikov wrote: > On 6 March 2018 at 09:57, Bas Nieuwenhuizen > wrote: > > > > > > On Tue, Mar 6, 2018 at 8:02 AM, Iago Toral > > wrote: > > > > > > On Mon, 2018-03-05 at 12:11 +, Emil Velikov wrote: > > > > Hi

Re: [Mesa-dev] [PATCH] anv/entrypoints: VkGetDeviceProcAddr returns NULL for core instance commands

2018-03-06 Thread Emil Velikov
On 6 March 2018 at 09:57, Bas Nieuwenhuizen wrote: > > > On Tue, Mar 6, 2018 at 8:02 AM, Iago Toral wrote: >> >> On Mon, 2018-03-05 at 12:11 +, Emil Velikov wrote: >> > Hi Iago, >> > >> > Top level questions: >> > >> > I think this and the original

Re: [Mesa-dev] [PATCH] anv/entrypoints: VkGetDeviceProcAddr returns NULL for core instance commands

2018-03-06 Thread Bas Nieuwenhuizen
On Tue, Mar 6, 2018 at 8:02 AM, Iago Toral wrote: > On Mon, 2018-03-05 at 12:11 +, Emil Velikov wrote: > > Hi Iago, > > > > Top level questions: > > > > I think this and the original commit should go to stable right? > > I am not sure if this qualifies for stable: these

Re: [Mesa-dev] [PATCH] anv/entrypoints: VkGetDeviceProcAddr returns NULL for core instance commands

2018-03-05 Thread Iago Toral
On Mon, 2018-03-05 at 12:11 +, Emil Velikov wrote: > Hi Iago, > > Top level questions: > > I think this and the original commit should go to stable right? I am not sure if this qualifies for stable: these patches don't fix any user-visible bugs. If an application was calling

Re: [Mesa-dev] [PATCH] anv/entrypoints: VkGetDeviceProcAddr returns NULL for core instance commands

2018-03-05 Thread Emil Velikov
Hi Iago, Top level questions: I think this and the original commit should go to stable right? The dispatch in 17.3 is very different making, yet 18.0 should be perfectly fine. Mildly related - anv is missing a special case for following three extensions. Should we port those over from radv?