Re: [Mesa-dev] [PATCH] anv: Check for VK_WHOLE_SIZE in anv_CmdFillBuffer

[Jason Ekstrand]

On Fri, Sep 23, 2016 at 6:19 AM, Jason Ekstrand 
wrote:

> On Wed, Sep 21, 2016 at 10:29 PM, Jason Ekstrand 
> wrote:
>
>> On Wed, Sep 21, 2016 at 3:40 PM, Nicolas Koch 
>> wrote:
>>
>>> Hey Jason, thanks for reviewing.
>>>
>>> This is my first mesa contribution, and I'm not really familiar with
>>> the mailing-list workflow.
>>>
>>
>> Thanks for the contribution and welcome to mesa!
>>
>>
>>> Is there anything else I need to do to get this merged? Or will
>>> someone just do it in the near future?
>>>
>>
>> Other than bugging one of the reviewers to push it for you, no.  Seeing
>> as you've already done that... I'll push it some time today. :-)
>>
>
> A day later than advertised, bug
>

Gah!  I meant to say "but pushed"


> On Tue, Sep 20, 2016 at 7:09 PM, Jason Ekstrand 
>>> wrote:
>>> > Seems reasonable
>>> >
>>> > Reviewed-by: Jason Ekstrand 
>>> >
>>> > This reminds me that we really need to convert CmdFillBuffer over to
>>> using
>>> > blorp...
>>> >
>>> >
>>> > On Sep 20, 2016 6:37 PM, "Nicolas Koch"  wrote:
>>> >>
>>> >> Vulkan spec:
>>> >> Size is the number of bytes to fill, and must be either a multiple of
>>> 4,
>>> >> or VK_WHOLE_SIZE to fill the range from offset to the end of the
>>> buffer.
>>> >> If VK_WHOLE_SIZE is used and the remaining size of the buffer is not a
>>> >> multiple of 4, then the nearest smaller multiple is used.
>>> >> ---
>>> >>  src/intel/vulkan/anv_meta_clear.c | 6 ++
>>> >>  1 file changed, 6 insertions(+)
>>> >>
>>> >> diff --git a/src/intel/vulkan/anv_meta_clear.c
>>> >> b/src/intel/vulkan/anv_meta_clear.c
>>> >> index ed4d1db..fd0797f 100644
>>> >> --- a/src/intel/vulkan/anv_meta_clear.c
>>> >> +++ b/src/intel/vulkan/anv_meta_clear.c
>>> >> @@ -1012,6 +1012,12 @@ void anv_CmdFillBuffer(
>>> >>
>>> >> meta_clear_begin(_state, cmd_buffer);
>>> >>
>>> >> +   if (fillSize == VK_WHOLE_SIZE) {
>>> >> +  fillSize = dst_buffer->size - dstOffset;
>>> >> +  /* Make sure fillSize is a multiple of 4 */
>>> >> +  fillSize -= fillSize & 3;
>>> >> +   }
>>> >> +
>>> >> VkFormat format;
>>> >> int bs;
>>> >> if ((fillSize & 15) == 0 && (dstOffset & 15) == 0) {
>>> >> --
>>> >> 2.10.0
>>> >>
>>> >> ___
>>> >> mesa-dev mailing list
>>> >> mesa-dev@lists.freedesktop.org
>>> >> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>>
>>
>>
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] anv: Check for VK_WHOLE_SIZE in anv_CmdFillBuffer

[Jason Ekstrand]

On Wed, Sep 21, 2016 at 10:29 PM, Jason Ekstrand 
wrote:

> On Wed, Sep 21, 2016 at 3:40 PM, Nicolas Koch  wrote:
>
>> Hey Jason, thanks for reviewing.
>>
>> This is my first mesa contribution, and I'm not really familiar with
>> the mailing-list workflow.
>>
>
> Thanks for the contribution and welcome to mesa!
>
>
>> Is there anything else I need to do to get this merged? Or will
>> someone just do it in the near future?
>>
>
> Other than bugging one of the reviewers to push it for you, no.  Seeing as
> you've already done that... I'll push it some time today. :-)
>

A day later than advertised, bug


> On Tue, Sep 20, 2016 at 7:09 PM, Jason Ekstrand 
>> wrote:
>> > Seems reasonable
>> >
>> > Reviewed-by: Jason Ekstrand 
>> >
>> > This reminds me that we really need to convert CmdFillBuffer over to
>> using
>> > blorp...
>> >
>> >
>> > On Sep 20, 2016 6:37 PM, "Nicolas Koch"  wrote:
>> >>
>> >> Vulkan spec:
>> >> Size is the number of bytes to fill, and must be either a multiple of
>> 4,
>> >> or VK_WHOLE_SIZE to fill the range from offset to the end of the
>> buffer.
>> >> If VK_WHOLE_SIZE is used and the remaining size of the buffer is not a
>> >> multiple of 4, then the nearest smaller multiple is used.
>> >> ---
>> >>  src/intel/vulkan/anv_meta_clear.c | 6 ++
>> >>  1 file changed, 6 insertions(+)
>> >>
>> >> diff --git a/src/intel/vulkan/anv_meta_clear.c
>> >> b/src/intel/vulkan/anv_meta_clear.c
>> >> index ed4d1db..fd0797f 100644
>> >> --- a/src/intel/vulkan/anv_meta_clear.c
>> >> +++ b/src/intel/vulkan/anv_meta_clear.c
>> >> @@ -1012,6 +1012,12 @@ void anv_CmdFillBuffer(
>> >>
>> >> meta_clear_begin(_state, cmd_buffer);
>> >>
>> >> +   if (fillSize == VK_WHOLE_SIZE) {
>> >> +  fillSize = dst_buffer->size - dstOffset;
>> >> +  /* Make sure fillSize is a multiple of 4 */
>> >> +  fillSize -= fillSize & 3;
>> >> +   }
>> >> +
>> >> VkFormat format;
>> >> int bs;
>> >> if ((fillSize & 15) == 0 && (dstOffset & 15) == 0) {
>> >> --
>> >> 2.10.0
>> >>
>> >> ___
>> >> mesa-dev mailing list
>> >> mesa-dev@lists.freedesktop.org
>> >> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>
>
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] anv: Check for VK_WHOLE_SIZE in anv_CmdFillBuffer

[Jason Ekstrand]

On Wed, Sep 21, 2016 at 3:40 PM, Nicolas Koch  wrote:

> Hey Jason, thanks for reviewing.
>
> This is my first mesa contribution, and I'm not really familiar with
> the mailing-list workflow.
>

Thanks for the contribution and welcome to mesa!


> Is there anything else I need to do to get this merged? Or will
> someone just do it in the near future?
>

Other than bugging one of the reviewers to push it for you, no.  Seeing as
you've already done that... I'll push it some time today. :-)


> On Tue, Sep 20, 2016 at 7:09 PM, Jason Ekstrand 
> wrote:
> > Seems reasonable
> >
> > Reviewed-by: Jason Ekstrand 
> >
> > This reminds me that we really need to convert CmdFillBuffer over to
> using
> > blorp...
> >
> >
> > On Sep 20, 2016 6:37 PM, "Nicolas Koch"  wrote:
> >>
> >> Vulkan spec:
> >> Size is the number of bytes to fill, and must be either a multiple of 4,
> >> or VK_WHOLE_SIZE to fill the range from offset to the end of the buffer.
> >> If VK_WHOLE_SIZE is used and the remaining size of the buffer is not a
> >> multiple of 4, then the nearest smaller multiple is used.
> >> ---
> >>  src/intel/vulkan/anv_meta_clear.c | 6 ++
> >>  1 file changed, 6 insertions(+)
> >>
> >> diff --git a/src/intel/vulkan/anv_meta_clear.c
> >> b/src/intel/vulkan/anv_meta_clear.c
> >> index ed4d1db..fd0797f 100644
> >> --- a/src/intel/vulkan/anv_meta_clear.c
> >> +++ b/src/intel/vulkan/anv_meta_clear.c
> >> @@ -1012,6 +1012,12 @@ void anv_CmdFillBuffer(
> >>
> >> meta_clear_begin(_state, cmd_buffer);
> >>
> >> +   if (fillSize == VK_WHOLE_SIZE) {
> >> +  fillSize = dst_buffer->size - dstOffset;
> >> +  /* Make sure fillSize is a multiple of 4 */
> >> +  fillSize -= fillSize & 3;
> >> +   }
> >> +
> >> VkFormat format;
> >> int bs;
> >> if ((fillSize & 15) == 0 && (dstOffset & 15) == 0) {
> >> --
> >> 2.10.0
> >>
> >> ___
> >> mesa-dev mailing list
> >> mesa-dev@lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] anv: Check for VK_WHOLE_SIZE in anv_CmdFillBuffer

[Jason Ekstrand]

Seems reasonable

Reviewed-by: Jason Ekstrand 

This reminds me that we really need to convert CmdFillBuffer over to using
blorp...

On Sep 20, 2016 6:37 PM, "Nicolas Koch"  wrote:

> Vulkan spec:
> Size is the number of bytes to fill, and must be either a multiple of 4,
> or VK_WHOLE_SIZE to fill the range from offset to the end of the buffer.
> If VK_WHOLE_SIZE is used and the remaining size of the buffer is not a
> multiple of 4, then the nearest smaller multiple is used.
> ---
>  src/intel/vulkan/anv_meta_clear.c | 6 ++
>  1 file changed, 6 insertions(+)
>
> diff --git a/src/intel/vulkan/anv_meta_clear.c
> b/src/intel/vulkan/anv_meta_clear.c
> index ed4d1db..fd0797f 100644
> --- a/src/intel/vulkan/anv_meta_clear.c
> +++ b/src/intel/vulkan/anv_meta_clear.c
> @@ -1012,6 +1012,12 @@ void anv_CmdFillBuffer(
>
> meta_clear_begin(_state, cmd_buffer);
>
> +   if (fillSize == VK_WHOLE_SIZE) {
> +  fillSize = dst_buffer->size - dstOffset;
> +  /* Make sure fillSize is a multiple of 4 */
> +  fillSize -= fillSize & 3;
> +   }
> +
> VkFormat format;
> int bs;
> if ((fillSize & 15) == 0 && (dstOffset & 15) == 0) {
> --
> 2.10.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev