Re: [Mesa-dev] [PATCH] blorp: Silence unused function warnings

2018-04-11 Thread Nanley Chery 
On Wed, Apr 11, 2018 at 11:24:00AM -0700, Lionel Landwerlin wrote:
> Reviewed-by: Lionel Landwerlin 
> 

Thanks! And pushed.

> On 11/04/18 11:00, Nanley Chery wrote:
> > vulkan/genX_blorp_exec.c:69:1: warning: ‘blorp_get_surface_base_address’ 
> > defined but not used [-Wunused-function]
> >   blorp_get_surface_base_address(struct blorp_batch *batch)
> >   ^~
> > In file included from vulkan/genX_blorp_exec.c:35:0:
> > ./blorp/blorp_genX_exec.h:1249:1: warning: ‘blorp_emit_memcpy’ defined but 
> > not used [-Wunused-function]
> >   blorp_emit_memcpy(struct blorp_batch *batch,
> >   ^
> > genX_blorp_exec.c:99:1: warning: ‘blorp_get_surface_base_address’ defined 
> > but not used [-Wunused-function]
> >   blorp_get_surface_base_address(struct blorp_batch *batch)
> >   ^~
> > In file included from genX_blorp_exec.c:33:0:
> > ../../../../../src/intel/blorp/blorp_genX_exec.h:1249:1: warning: 
> > ‘blorp_emit_memcpy’ defined but not used [-Wunused-function]
> >   blorp_emit_memcpy(struct blorp_batch *batch,
> >   ^
> > ---
> >   src/intel/blorp/blorp_genX_exec.h   | 4 ++--
> >   src/intel/vulkan/genX_blorp_exec.c  | 2 +-
> >   src/mesa/drivers/dri/i965/genX_blorp_exec.c | 2 +-
> >   3 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/src/intel/blorp/blorp_genX_exec.h 
> > b/src/intel/blorp/blorp_genX_exec.h
> > index 7851228d8dc..593521b95cc 100644
> > --- a/src/intel/blorp/blorp_genX_exec.h
> > +++ b/src/intel/blorp/blorp_genX_exec.h
> > @@ -78,7 +78,7 @@ static void
> >   blorp_surface_reloc(struct blorp_batch *batch, uint32_t ss_offset,
> >   struct blorp_address address, uint32_t delta);
> > -#if GEN_GEN >= 7 && GEN_GEN <= 10
> > +#if GEN_GEN >= 7 && GEN_GEN < 10
> >   static struct blorp_address
> >   blorp_get_surface_base_address(struct blorp_batch *batch);
> >   #endif
> > @@ -1244,7 +1244,7 @@ blorp_emit_pipeline(struct blorp_batch *batch,
> >   #endif /* GEN_GEN >= 6 */
> > -#if GEN_GEN >= 7 && GEN_GEN <= 10
> > +#if GEN_GEN >= 7 && GEN_GEN < 10
> >   static void
> >   blorp_emit_memcpy(struct blorp_batch *batch,
> > struct blorp_address dst,
> > diff --git a/src/intel/vulkan/genX_blorp_exec.c 
> > b/src/intel/vulkan/genX_blorp_exec.c
> > index 1ecec199846..b423046d616 100644
> > --- a/src/intel/vulkan/genX_blorp_exec.c
> > +++ b/src/intel/vulkan/genX_blorp_exec.c
> > @@ -64,7 +64,7 @@ blorp_surface_reloc(struct blorp_batch *batch, uint32_t 
> > ss_offset,
> > anv_batch_set_error(_buffer->batch, result);
> >   }
> > -#if GEN_GEN >= 7 && GEN_GEN <= 10
> > +#if GEN_GEN >= 7 && GEN_GEN < 10
> >   static struct blorp_address
> >   blorp_get_surface_base_address(struct blorp_batch *batch)
> >   {
> > diff --git a/src/mesa/drivers/dri/i965/genX_blorp_exec.c 
> > b/src/mesa/drivers/dri/i965/genX_blorp_exec.c
> > index 3406a6fdec6..b72ca9c515b 100644
> > --- a/src/mesa/drivers/dri/i965/genX_blorp_exec.c
> > +++ b/src/mesa/drivers/dri/i965/genX_blorp_exec.c
> > @@ -94,7 +94,7 @@ blorp_surface_reloc(struct blorp_batch *batch, uint32_t 
> > ss_offset,
> >   #endif
> >   }
> > -#if GEN_GEN >= 7 && GEN_GEN <= 10
> > +#if GEN_GEN >= 7 && GEN_GEN < 10
> >   static struct blorp_address
> >   blorp_get_surface_base_address(struct blorp_batch *batch)
> >   {
> 
> 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] blorp: Silence unused function warnings

2018-04-11 Thread Lionel Landwerlin 

Reviewed-by: Lionel Landwerlin 

On 11/04/18 11:00, Nanley Chery wrote:

vulkan/genX_blorp_exec.c:69:1: warning: ‘blorp_get_surface_base_address’ 
defined but not used [-Wunused-function]
  blorp_get_surface_base_address(struct blorp_batch *batch)
  ^~
In file included from vulkan/genX_blorp_exec.c:35:0:
./blorp/blorp_genX_exec.h:1249:1: warning: ‘blorp_emit_memcpy’ defined but not 
used [-Wunused-function]
  blorp_emit_memcpy(struct blorp_batch *batch,
  ^
genX_blorp_exec.c:99:1: warning: ‘blorp_get_surface_base_address’ defined but 
not used [-Wunused-function]
  blorp_get_surface_base_address(struct blorp_batch *batch)
  ^~
In file included from genX_blorp_exec.c:33:0:
../../../../../src/intel/blorp/blorp_genX_exec.h:1249:1: warning: 
‘blorp_emit_memcpy’ defined but not used [-Wunused-function]
  blorp_emit_memcpy(struct blorp_batch *batch,
  ^
---
  src/intel/blorp/blorp_genX_exec.h   | 4 ++--
  src/intel/vulkan/genX_blorp_exec.c  | 2 +-
  src/mesa/drivers/dri/i965/genX_blorp_exec.c | 2 +-
  3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/intel/blorp/blorp_genX_exec.h 
b/src/intel/blorp/blorp_genX_exec.h
index 7851228d8dc..593521b95cc 100644
--- a/src/intel/blorp/blorp_genX_exec.h
+++ b/src/intel/blorp/blorp_genX_exec.h
@@ -78,7 +78,7 @@ static void
  blorp_surface_reloc(struct blorp_batch *batch, uint32_t ss_offset,
  struct blorp_address address, uint32_t delta);
  
-#if GEN_GEN >= 7 && GEN_GEN <= 10

+#if GEN_GEN >= 7 && GEN_GEN < 10
  static struct blorp_address
  blorp_get_surface_base_address(struct blorp_batch *batch);
  #endif
@@ -1244,7 +1244,7 @@ blorp_emit_pipeline(struct blorp_batch *batch,
  
  #endif /* GEN_GEN >= 6 */
  
-#if GEN_GEN >= 7 && GEN_GEN <= 10

+#if GEN_GEN >= 7 && GEN_GEN < 10
  static void
  blorp_emit_memcpy(struct blorp_batch *batch,
struct blorp_address dst,
diff --git a/src/intel/vulkan/genX_blorp_exec.c 
b/src/intel/vulkan/genX_blorp_exec.c
index 1ecec199846..b423046d616 100644
--- a/src/intel/vulkan/genX_blorp_exec.c
+++ b/src/intel/vulkan/genX_blorp_exec.c
@@ -64,7 +64,7 @@ blorp_surface_reloc(struct blorp_batch *batch, uint32_t 
ss_offset,
anv_batch_set_error(_buffer->batch, result);
  }
  
-#if GEN_GEN >= 7 && GEN_GEN <= 10

+#if GEN_GEN >= 7 && GEN_GEN < 10
  static struct blorp_address
  blorp_get_surface_base_address(struct blorp_batch *batch)
  {
diff --git a/src/mesa/drivers/dri/i965/genX_blorp_exec.c 
b/src/mesa/drivers/dri/i965/genX_blorp_exec.c
index 3406a6fdec6..b72ca9c515b 100644
--- a/src/mesa/drivers/dri/i965/genX_blorp_exec.c
+++ b/src/mesa/drivers/dri/i965/genX_blorp_exec.c
@@ -94,7 +94,7 @@ blorp_surface_reloc(struct blorp_batch *batch, uint32_t 
ss_offset,
  #endif
  }
  
-#if GEN_GEN >= 7 && GEN_GEN <= 10

+#if GEN_GEN >= 7 && GEN_GEN < 10
  static struct blorp_address
  blorp_get_surface_base_address(struct blorp_batch *batch)
  {



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev