Re: [Mesa-dev] [PATCH] egl/android: fix error in droid_add_configs_for_visuals()

2016-10-17 Thread Eric Engestrom 
On Monday, 2016-10-17 12:04:00 +0100, Emil Velikov wrote:
> On 17 October 2016 at 07:04, Tapani Pälli  wrote:
> > This was some kind of leftover in commit acd35c8 and format_count
> > array variable (declared in outer scope) should be used instead.
> >
> Which brings the question - do we want to enable -Wshadow for the C
> sources. The C++ ones [used to] produce too much noise so they're out
> of the question.

I just had a look at what -Wshadow shows, and it's quite spammy at the
moment, so we might want to have a few cleanup commits before enabling
it, but most of them are just generic var names that could be improved
anyway (color, index, block, etc.). A few of those are in macros, making
the spam even worse, but at the same time easier to fix :)

This var name cleanup sounds like a good introduction task for a newbie,
as it will get you to dive all over the code and have to read a bunch of
code blocks to figure out better names.
I don't have much free time right now anyway, so if no-one's done it by
the time I do (probably in 2-3 weeks) I'll give it a go.

Cheers,
  Eric

> 
> Either way, r-b and pushed to master.
> 
> Thanks
> Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] egl/android: fix error in droid_add_configs_for_visuals()

2016-10-17 Thread Emil Velikov 
On 17 October 2016 at 07:04, Tapani Pälli  wrote:
> This was some kind of leftover in commit acd35c8 and format_count
> array variable (declared in outer scope) should be used instead.
>
Which brings the question - do we want to enable -Wshadow for the C
sources. The C++ ones [used to] produce too much noise so they're out
of the question.

Either way, r-b and pushed to master.

Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] egl/android: fix error in droid_add_configs_for_visuals()

2016-10-17 Thread Eric Engestrom 
On Monday, 2016-10-17 09:04:56 +0300, Tapani Pälli wrote:
> This was some kind of leftover in commit acd35c8 and format_count
> array variable (declared in outer scope) should be used instead.
> 
> Signed-off-by: Tapani Pälli 

Fixes: acd35c8758dc73240903 ("egl/android: tweak 
droid_add_configs_for_visuals()")
Reviewed-by: Eric Engestrom 

> ---
>  src/egl/drivers/dri2/platform_android.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/egl/drivers/dri2/platform_android.c 
> b/src/egl/drivers/dri2/platform_android.c
> index 6a4122a..6a110e2 100644
> --- a/src/egl/drivers/dri2/platform_android.c
> +++ b/src/egl/drivers/dri2/platform_android.c
> @@ -787,8 +787,6 @@ droid_add_configs_for_visuals(_EGLDriver *drv, 
> _EGLDisplay *dpy)
>   continue;
>  
>for (j = 0; j < ARRAY_SIZE(visuals); j++) {
> - int format_count = 0;
> -
>   config_attrs[1] = visuals[j].format;
>   config_attrs[3] = visuals[j].format;
>  
> -- 
> 2.7.4
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev