Re: [Mesa-dev] [PATCH] gallium/hud: bugfix: 68169 - Sensor extensions segfaults.

2016-10-13 Thread Steven Toth
Hello Nicolai >> On inspection, this was due to the 'unigine' application >> created the HUD contexts twice (two screens?). The >> extensions had never been tested in that configuration, >> and the free_query_data() calls were thus trigger. > > > The HUD is actually created per-context. Two

Re: [Mesa-dev] [PATCH] gallium/hud: bugfix: 68169 - Sensor extensions segfaults.

2016-10-13 Thread Emil Velikov
Hi Steven, On 12 October 2016 at 18:02, Steven Toth wrote: > https://bugs.freedesktop.org/show_bug.cgi?id=98169 > Just a general comment/suggestion: Don't include bug# in the commit summary. Having it as Bugzilla: https... towards the end of the description. Aside: if you

Re: [Mesa-dev] [PATCH] gallium/hud: bugfix: 68169 - Sensor extensions segfaults.

2016-10-13 Thread Nicolai Hähnle
On 12.10.2016 19:02, Steven Toth wrote: https://bugs.freedesktop.org/show_bug.cgi?id=98169 Really a two part bug. 1. The recent extensions to the HUB framework were tested exclusively with glxgears/demo/head. None of these tools exercise the free_query_data() code path. When these codepaths