Re: [Mesa-dev] [PATCH] gallium/winsys/kms: Add support for multi-planes (v2)

2018-03-07 Thread Lepton Wu
Thanks for reviewing, just back from vacation and send out V3 for review. I split it to 2 patches now and I removed lazy unmap since it's unnecessary. On Wed, Feb 21, 2018 at 7:42 AM, Emil Velikov wrote: > HI Lepton, > > It seems that this has fallen through the cracks.

Re: [Mesa-dev] [PATCH] gallium/winsys/kms: Add support for multi-planes (v2)

2018-02-21 Thread Emil Velikov
HI Lepton, It seems that this has fallen through the cracks. There's one important functionality change which should be split out and documented. The rest is just style nitpicks. On 28 December 2017 at 07:35, Lepton Wu wrote: > v2: address comments from Tomasz Figa >a)

Re: [Mesa-dev] [PATCH] gallium/winsys/kms: Add support for multi-planes (v2)

2018-01-31 Thread Tomasz Figa
On Tue, Jan 9, 2018 at 6:15 PM, Tomasz Figa wrote: > Adding some folks on CC for broader distribution. > > On Tue, Jan 9, 2018 at 3:52 PM, Lepton Wu wrote: >> Gentle ping. Thanks. >> >> On Wed, Dec 27, 2017 at 11:35 PM, Lepton Wu

Re: [Mesa-dev] [PATCH] gallium/winsys/kms: Add support for multi-planes (v2)

2018-01-09 Thread Tomasz Figa
Adding some folks on CC for broader distribution. On Tue, Jan 9, 2018 at 3:52 PM, Lepton Wu wrote: > Gentle ping. Thanks. > > On Wed, Dec 27, 2017 at 11:35 PM, Lepton Wu wrote: >> v2: address comments from Tomasz Figa >>a) Add more check for plane

Re: [Mesa-dev] [PATCH] gallium/winsys/kms: Add support for multi-planes (v2)

2018-01-09 Thread Lepton Wu
Gentle ping. Thanks. On Wed, Dec 27, 2017 at 11:35 PM, Lepton Wu wrote: > v2: address comments from Tomasz Figa >a) Add more check for plane size. >b) Avoid duplicated mapping and leaked mapping. >c) Other minor changes. > > Signed-off-by: Lepton Wu