Re: [Mesa-dev] [PATCH] i965/gen8+: Enable GL_OES_viewport_array

2016-09-29 Thread Ilia Mirkin 
On Thu, Sep 29, 2016 at 2:40 PM, Anuj Phogat  wrote:
> On Thu, Sep 22, 2016 at 5:59 PM, Ilia Mirkin  wrote:
>> On Wed, Sep 21, 2016 at 2:15 PM, Anuj Phogat  wrote:
>>> Signed-off-by: Anuj Phogat 
>>>
>>> ---
>>> This patch requires below series:
>>> https://patchwork.freedesktop.org/series/12594/
>>
>> FYI, this is now pushed. Given that the ext relies on
>> OES_geometry_shader, the placement of the enable makes sense. However
>> all 3 of these should probably go into the gen7.5 section since HSW
>> now has ES 3.1 as well. But that should be done later. As is, this is
>>
> Testing showed that I either have to enable ARB_viewport_array along
> with OES_viewport_array in GLES contexts or expose the enums
> for OES_Viewport_array. I'm sending out few patches to fix these issues.

I was aware of this. I didn't think it'd be an issue.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/gen8+: Enable GL_OES_viewport_array

2016-09-29 Thread Anuj Phogat 
On Thu, Sep 22, 2016 at 5:59 PM, Ilia Mirkin  wrote:
> On Wed, Sep 21, 2016 at 2:15 PM, Anuj Phogat  wrote:
>> Signed-off-by: Anuj Phogat 
>>
>> ---
>> This patch requires below series:
>> https://patchwork.freedesktop.org/series/12594/
>
> FYI, this is now pushed. Given that the ext relies on
> OES_geometry_shader, the placement of the enable makes sense. However
> all 3 of these should probably go into the gen7.5 section since HSW
> now has ES 3.1 as well. But that should be done later. As is, this is
>
Testing showed that I either have to enable ARB_viewport_array along
with OES_viewport_array in GLES contexts or expose the enums
for OES_Viewport_array. I'm sending out few patches to fix these issues.

I also tried enabling OES_geometry_shader and OES_viewport_array
on hsw but hit some khronos cts regressions. I'll work on them.

> Reviewed-by: Ilia Mirkin 
>
>> ---
>>  src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c 
>> b/src/mesa/drivers/dri/i965/intel_extensions.c
>> index 93eb966..53bd7cc 100644
>> --- a/src/mesa/drivers/dri/i965/intel_extensions.c
>> +++ b/src/mesa/drivers/dri/i965/intel_extensions.c
>> @@ -404,6 +404,7 @@ intelInitExtensions(struct gl_context *ctx)
>>ctx->Extensions.ARB_ES3_2_compatibility = true;
>>ctx->Extensions.OES_geometry_shader = true;
>>ctx->Extensions.OES_texture_cube_map_array = true;
>> +  ctx->Extensions.OES_viewport_array = true;
>> }
>>
>> if (brw->gen >= 9) {
>> --
>> 2.5.5
>>
>> ___
>> mesa-dev mailing list
>> mesa-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/gen8+: Enable GL_OES_viewport_array

2016-09-22 Thread Ilia Mirkin 
On Wed, Sep 21, 2016 at 2:15 PM, Anuj Phogat  wrote:
> Signed-off-by: Anuj Phogat 
>
> ---
> This patch requires below series:
> https://patchwork.freedesktop.org/series/12594/

FYI, this is now pushed. Given that the ext relies on
OES_geometry_shader, the placement of the enable makes sense. However
all 3 of these should probably go into the gen7.5 section since HSW
now has ES 3.1 as well. But that should be done later. As is, this is

Reviewed-by: Ilia Mirkin 

> ---
>  src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c 
> b/src/mesa/drivers/dri/i965/intel_extensions.c
> index 93eb966..53bd7cc 100644
> --- a/src/mesa/drivers/dri/i965/intel_extensions.c
> +++ b/src/mesa/drivers/dri/i965/intel_extensions.c
> @@ -404,6 +404,7 @@ intelInitExtensions(struct gl_context *ctx)
>ctx->Extensions.ARB_ES3_2_compatibility = true;
>ctx->Extensions.OES_geometry_shader = true;
>ctx->Extensions.OES_texture_cube_map_array = true;
> +  ctx->Extensions.OES_viewport_array = true;
> }
>
> if (brw->gen >= 9) {
> --
> 2.5.5
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev