The patch seems to be safe, so yes, thanks.
On 8/21/18 1:17 AM, Andres Gomez wrote:
Danylo, should we also include this in the stable queues ?
On Mon, 2018-06-18 at 15:50 +0300, Danylo Piliaiev wrote:
We use floating-points for viewport bounds so VIEWPORT_SUBPIXEL_BITS
should reflect this.
Hey Andres,
Yes, it should. Sorry I missed the Cc stable in the patch.
Thanks for paying attention :)
-
Lionel
On 20/08/2018 23:17, Andres Gomez wrote:
Danylo, should we also include this in the stable queues ?
On Mon, 2018-06-18 at 15:50 +0300, Danylo Piliaiev wrote:
We use
Danylo, should we also include this in the stable queues ?
On Mon, 2018-06-18 at 15:50 +0300, Danylo Piliaiev wrote:
> We use floating-points for viewport bounds so VIEWPORT_SUBPIXEL_BITS
> should reflect this.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105975
>
>
On 8/20/18 4:28 PM, Lionel Landwerlin wrote:
Reviewed-by: Lionel Landwerlin
Thanks!
Do you need me to push it?
Yes
Thanks,
-
Lionel
On 08/08/18 16:03, Danylo Piliaiev wrote:
Hi,
Since the exact value is not important for users, Roland offered
compelling explanation
and the value
Reviewed-by: Lionel Landwerlin
Do you need me to push it?
Thanks,
-
Lionel
On 08/08/18 16:03, Danylo Piliaiev wrote:
Hi,
Since the exact value is not important for users, Roland offered
compelling explanation
and the value is also 8 on Windows - could the patch be reviewed/pushed?
-
Hi,
Since the exact value is not important for users, Roland offered
compelling explanation
and the value is also 8 on Windows - could the patch be reviewed/pushed?
- Danil
On 06/19/2018 03:44 PM, Roland Scheidegger wrote:
My guess would be 8 because that's what the rasterization subpixel
My guess would be 8 because that's what the rasterization subpixel
precision is, so precision beyond that doesn't really do much, even if
this actually is a float.
Plus, with maximum sized fb (16kx16k dimension) you don't actually
really get a lot more than 8 fixed points bits anyway (near those
Hi Lionel,
Indeed the value 8 here is questionable. I picked it because other
drivers advertise the same value e.g. in Mesa radeon returns 8 for gl
and vulkan or on Windows Intel's driver returns 8. But why 8? It's some
kind of mystery.
"If the implementation truely has floating point
Hey Danylo,
Thanks for this patch.
I'm not really an expert here but my understanding is that it should
reflect the number of bits in fixed point precision.
We use 32bits floats in the packets sent to the hardware.
Quoting the spec :
"If the implementation truely has floating point viewport
