Re: [Mesa-dev] [PATCH] mesa: Update vertex processing mode on _mesa_UseProgram.

[Mathias Fröhlich]

Hi Clayton,

On Friday, 23 February 2018 22:44:09 CET Clayton Craft wrote:
> On Fri, Feb 23, 2018 at 09:01:17PM +0100, mathias.froehl...@gmx.net wrote:
> >From: Mathias Fröhlich 
> >
> >Hi Clayton,
> >
> >The following change fixes the reported problem on my site.
> >Please test/review!!
> Just ran this through the CI and the previously failing test is now passing.
> 
> I can also set up the CI to automatically build a branch of your choice 
(e.g. in
> your personal mesa repo) when you push to it, to help with testing your
> commits before they are pushed to the master branch. Would you like for me 
to
> do this?
> If so, I just need to know the location of your repo and the branch you 
would
> like pushes to trigger a CI build on.

Since I have some more pending stuff, that sounds like an offer.
So yes, I have pushed the next step onto my personal freedesktop mesa 'git://
people.freedesktop.org/~frohlich/mesa' as branch 'for-CI'.

Does that offered CI build also check for changes in the intermediate commits 
or does it only check the last commit on the mentioned branch?

best

Mathias


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa: Update vertex processing mode on _mesa_UseProgram.

[Mathias Fröhlich]

Hi,

On Friday, 23 February 2018 22:26:21 CET Ilia Mirkin wrote:
> >> Fixes: KHR-GLES31.core.shader_image_load_store.advanced-sso-simple
> >
> > The "Fixes:" tag is supposed to indicate the git commit which regresses
> > Mesa.  Release automation processes it when preparing branches for the
> > stable release.
> >
> > https://www.mesa3d.org/submittingpatches.html#formatting
> >
> > In this case, the patch doesn't need to be applied to a stable branch.
> > However, it may confuse the automation.
> 
> It's pretty common practice to do this... should be easy enough to
> teach automation to skip if it's not a hash-looking thing.

Ah I see, that Fixes should contain the commit that it actually fixes.
Will do so in the future.

best

Mathias



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa: Update vertex processing mode on _mesa_UseProgram.

[Clayton Craft]

On Fri, Feb 23, 2018 at 09:01:17PM +0100, mathias.froehl...@gmx.net wrote:

From: Mathias Fröhlich 

Hi Clayton,

The following change fixes the reported problem on my site.
Please test/review!!

Just ran this through the CI and the previously failing test is now passing.

I can also set up the CI to automatically build a branch of your choice (e.g. in
your personal mesa repo) when you push to it, to help with testing your
commits before they are pushed to the master branch. Would you like for me to
do this?
If so, I just need to know the location of your repo and the branch you would
like pushes to trigger a CI build on.



best

Mathias


The change is a bug fix for 92d76a169:
 mesa: Provide an alternative to get_vp_mode()
that actually got exposed through 4562a7b0:
 vbo: Make use of _DrawVAO from the dlist code.

Fixes: KHR-GLES31.core.shader_image_load_store.advanced-sso-simple
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105229
Signed-off-by: Mathias Fröhlich 
---
src/mesa/main/shaderapi.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c
index d8a3031a38..b7bd7167e1 100644
--- a/src/mesa/main/shaderapi.c
+++ b/src/mesa/main/shaderapi.c
@@ -2069,6 +2069,8 @@ use_program(GLuint program, bool no_error)
_mesa_BindProgramPipeline(ctx->Pipeline.Current->Name);
  }
   }
+
+   _mesa_update_vertex_processing_mode(ctx);
}


--
2.14.3



signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa: Update vertex processing mode on _mesa_UseProgram.

[Ilia Mirkin]

On Fri, Feb 23, 2018 at 4:24 PM, Mark Janes  wrote:
>  writes:
>
>> From: Mathias Fröhlich 
>>
>> Hi Clayton,
>>
>> The following change fixes the reported problem on my site.
>> Please test/review!!
>>
>> best
>>
>> Mathias
>>
>>
>> The change is a bug fix for 92d76a169:
>>   mesa: Provide an alternative to get_vp_mode()
>> that actually got exposed through 4562a7b0:
>>   vbo: Make use of _DrawVAO from the dlist code.
>>
>> Fixes: KHR-GLES31.core.shader_image_load_store.advanced-sso-simple
>
> The "Fixes:" tag is supposed to indicate the git commit which regresses
> Mesa.  Release automation processes it when preparing branches for the
> stable release.
>
> https://www.mesa3d.org/submittingpatches.html#formatting
>
> In this case, the patch doesn't need to be applied to a stable branch.
> However, it may confuse the automation.

It's pretty common practice to do this... should be easy enough to
teach automation to skip if it's not a hash-looking thing.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa: Update vertex processing mode on _mesa_UseProgram.

[Mark Janes]

 writes:

> From: Mathias Fröhlich 
>
> Hi Clayton,
>
> The following change fixes the reported problem on my site.
> Please test/review!!
>
> best
>
> Mathias
>
>
> The change is a bug fix for 92d76a169:
>   mesa: Provide an alternative to get_vp_mode()
> that actually got exposed through 4562a7b0:
>   vbo: Make use of _DrawVAO from the dlist code.
>
> Fixes: KHR-GLES31.core.shader_image_load_store.advanced-sso-simple

The "Fixes:" tag is supposed to indicate the git commit which regresses
Mesa.  Release automation processes it when preparing branches for the
stable release.

https://www.mesa3d.org/submittingpatches.html#formatting

In this case, the patch doesn't need to be applied to a stable branch.
However, it may confuse the automation.

> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105229
> Signed-off-by: Mathias Fröhlich 
> ---
>  src/mesa/main/shaderapi.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c
> index d8a3031a38..b7bd7167e1 100644
> --- a/src/mesa/main/shaderapi.c
> +++ b/src/mesa/main/shaderapi.c
> @@ -2069,6 +2069,8 @@ use_program(GLuint program, bool no_error)
>  _mesa_BindProgramPipeline(ctx->Pipeline.Current->Name);
>}
> }
> +
> +   _mesa_update_vertex_processing_mode(ctx);
>  }
>  
>  
> -- 
> 2.14.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa: Update vertex processing mode on _mesa_UseProgram.

[Mathias Fröhlich]

Hi Brian,

On Friday, 23 February 2018 21:04:54 CET Brian Paul wrote:
> LGTM.
> 
> Reviewed-by: Brian Paul 

Thanks!!
And pushed.

Mathias




___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa: Update vertex processing mode on _mesa_UseProgram.

[Brian Paul]

On 02/23/2018 01:01 PM, mathias.froehl...@gmx.net wrote:

From: Mathias Fröhlich 

Hi Clayton,

The following change fixes the reported problem on my site.
Please test/review!!

best

Mathias


The change is a bug fix for 92d76a169:
   mesa: Provide an alternative to get_vp_mode()
that actually got exposed through 4562a7b0:
   vbo: Make use of _DrawVAO from the dlist code.

Fixes: KHR-GLES31.core.shader_image_load_store.advanced-sso-simple
Bugzilla: 
https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.freedesktop.org_show-5Fbug.cgi-3Fid-3D105229=DwIDaQ=uilaK90D4TOVoH58JNXRgQ=Ie7_encNUsqxbSRbqbNgofw0ITcfE8JKfaUjIQhncGA=LBvaMymXijZu_rp52IqZ2veWUoxN9q6Gqh2JNWfIPc4=61pPMG-_G1myc2dJVu_9Ar9ghESnHBQE61Z9O4TQrAo=
Signed-off-by: Mathias Fröhlich 
---
  src/mesa/main/shaderapi.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c
index d8a3031a38..b7bd7167e1 100644
--- a/src/mesa/main/shaderapi.c
+++ b/src/mesa/main/shaderapi.c
@@ -2069,6 +2069,8 @@ use_program(GLuint program, bool no_error)
  _mesa_BindProgramPipeline(ctx->Pipeline.Current->Name);
}
 }
+
+   _mesa_update_vertex_processing_mode(ctx);
  }
  
  



LGTM.

Reviewed-by: Brian Paul 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev