Re: [Mesa-dev] [PATCH] mesa: define nir_spirv_supported_capabilities

2017-12-07 Thread Alejandro Piñeiro
On 07/12/17 06:23, Jason Ekstrand wrote: > On Wed, Dec 6, 2017 at 8:48 PM, Timothy Arceri > wrote: > > On 07/12/17 00:23, Alejandro Piñeiro wrote: > > On 06/12/17 13:29, Pierre Moreau wrote: > > Hello Alejandro, > >

Re: [Mesa-dev] [PATCH] mesa: define nir_spirv_supported_capabilities

2017-12-06 Thread Jason Ekstrand
On Wed, Dec 6, 2017 at 8:48 PM, Timothy Arceri wrote: > On 07/12/17 00:23, Alejandro Piñeiro wrote: > >> On 06/12/17 13:29, Pierre Moreau wrote: >> >>> Hello Alejandro, >>> >>> As far as I understand, nir_spirv_supported_capabilities is being >>> filled in by >>> the

Re: [Mesa-dev] [PATCH] mesa: define nir_spirv_supported_capabilities

2017-12-06 Thread Timothy Arceri
On 07/12/17 00:23, Alejandro Piñeiro wrote: On 06/12/17 13:29, Pierre Moreau wrote: Hello Alejandro, As far as I understand, nir_spirv_supported_capabilities is being filled in by the driver and then fetched by the API entrypoint to check the capabilities required by the SPIR-V binary given as

Re: [Mesa-dev] [PATCH] mesa: define nir_spirv_supported_capabilities

2017-12-06 Thread Ian Romanick
Reviewed-by: Ian Romanick On 12/06/2017 03:57 AM, Alejandro Piñeiro wrote: > Until now it was part of spirv_to_nir_options. But it will be used on > the implementation of ARB_gl_spirv and ARB_spirv_extensions, and added > to the OpenGL context, as a way to save what

Re: [Mesa-dev] [PATCH] mesa: define nir_spirv_supported_capabilities

2017-12-06 Thread Ian Romanick
On 12/06/2017 07:29 AM, Pierre Moreau wrote: > Hello Alejandro, > > As far as I understand, nir_spirv_supported_capabilities is being filled in by > the driver and then fetched by the API entrypoint to check the capabilities > required by the SPIR-V binary given as input. And this is done

Re: [Mesa-dev] [PATCH] mesa: define nir_spirv_supported_capabilities

2017-12-06 Thread Alejandro Piñeiro
On 06/12/17 13:29, Pierre Moreau wrote: > Hello Alejandro, > > As far as I understand, nir_spirv_supported_capabilities is being filled in by > the driver and then fetched by the API entrypoint to check the capabilities > required by the SPIR-V binary given as input. And this is done regardless of

Re: [Mesa-dev] [PATCH] mesa: define nir_spirv_supported_capabilities

2017-12-06 Thread Pierre Moreau
Hello Alejandro, As far as I understand, nir_spirv_supported_capabilities is being filled in by the driver and then fetched by the API entrypoint to check the capabilities required by the SPIR-V binary given as input. And this is done regardless of the input IR used by the driver, be it NIR, LLVM