Re: [Mesa-dev] [PATCH] meson: Fix GL and EGL pkg-config files withglvnd

2018-02-23 Thread Emil Velikov
On 23 February 2018 at 16:04, Marc Dietrich  wrote:
> Am Freitag, 23. Februar 2018, 16:57:18 CET schrieb Daniel Stone:
>> Hi Marc,
>>
>> On 23 February 2018 at 15:42, Marc Dietrich  wrote:
>> > Am Freitag, 23. Februar 2018, 14:31:30 CET schrieb Daniel Stone:
>> >> On 20 February 2018 at 18:36, Dylan Baker  wrote:
>> >> > Currently meson will generate a pkg-config that links to EGL_mesa (or
>> >> > GLX_mesa), but this isn't correct, it should always link to EGL or GL.
>> >> > Probably the "right" solution is to have glvnd itself provide the pkg
>> >> > config files for GL and EGL, but that also means that glvnd needs to
>> >> > provide many of the header files, which makes it a more involved job.
>> >>
>> >> Thanks for this! Reviewed and pushed.
>> >
>> > I think autotools build needs the same fix.
>>
>> autotools has an egl.pc.in file which very explicitly contains only -lEGL.
>
> right, I meant gl.pc.
>

Distributions had a very cross hack for close to an year now.
I'll do that in a second, it might be the quickest way to get it sorted.

Couple of thoughts about Dylan's patch
 a) fully agree with the TODO's
 b) having the libGL/glx hunk in src/{meson.build,Makefile.am} 'feels' wrong
It beats duplicating it in three places, though ;-)

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] meson: Fix GL and EGL pkg-config files withglvnd

2018-02-23 Thread Marc Dietrich
Am Freitag, 23. Februar 2018, 16:57:18 CET schrieb Daniel Stone:
> Hi Marc,
> 
> On 23 February 2018 at 15:42, Marc Dietrich  wrote:
> > Am Freitag, 23. Februar 2018, 14:31:30 CET schrieb Daniel Stone:
> >> On 20 February 2018 at 18:36, Dylan Baker  wrote:
> >> > Currently meson will generate a pkg-config that links to EGL_mesa (or
> >> > GLX_mesa), but this isn't correct, it should always link to EGL or GL.
> >> > Probably the "right" solution is to have glvnd itself provide the pkg
> >> > config files for GL and EGL, but that also means that glvnd needs to
> >> > provide many of the header files, which makes it a more involved job.
> >> 
> >> Thanks for this! Reviewed and pushed.
> > 
> > I think autotools build needs the same fix.
> 
> autotools has an egl.pc.in file which very explicitly contains only -lEGL.

right, I meant gl.pc.

Marc



signature.asc
Description: This is a digitally signed message part.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] meson: Fix GL and EGL pkg-config files withglvnd

2018-02-23 Thread Daniel Stone
Hi Marc,

On 23 February 2018 at 15:42, Marc Dietrich  wrote:
> Am Freitag, 23. Februar 2018, 14:31:30 CET schrieb Daniel Stone:
>> On 20 February 2018 at 18:36, Dylan Baker  wrote:
>> > Currently meson will generate a pkg-config that links to EGL_mesa (or
>> > GLX_mesa), but this isn't correct, it should always link to EGL or GL.
>> > Probably the "right" solution is to have glvnd itself provide the pkg
>> > config files for GL and EGL, but that also means that glvnd needs to
>> > provide many of the header files, which makes it a more involved job.
>>
>> Thanks for this! Reviewed and pushed.
>
> I think autotools build needs the same fix.

autotools has an egl.pc.in file which very explicitly contains only -lEGL.

Cheers,
Daniel
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] meson: Fix GL and EGL pkg-config files withglvnd

2018-02-23 Thread Marc Dietrich
Hi,

Am Freitag, 23. Februar 2018, 14:31:30 CET schrieb Daniel Stone:
> Hi Dylan,
> 
> On 20 February 2018 at 18:36, Dylan Baker  wrote:
> > Currently meson will generate a pkg-config that links to EGL_mesa (or
> > GLX_mesa), but this isn't correct, it should always link to EGL or GL.
> > Probably the "right" solution is to have glvnd itself provide the pkg
> > config files for GL and EGL, but that also means that glvnd needs to
> > provide many of the header files, which makes it a more involved job.
> 
> Thanks for this! Reviewed and pushed.

I think autotools build needs the same fix.

Marc


signature.asc
Description: This is a digitally signed message part.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev