Re: [Mesa-dev] [PATCH] nir: fix ir_binop_gequal glsl_to_nir conversion

2018-04-16 Thread Jason Ekstrand
Pushed. Thanks and welcome to Mesa! On April 14, 2018 12:26:18 Jason Ekstrand wrote: Reviewed-by: Jason Ekstrand What driver is hitting this path? The !supports_ints path isn't used to my knowledge so if some driver has started using it, they're

Re: [Mesa-dev] [PATCH] nir: fix ir_binop_gequal glsl_to_nir conversion

2018-04-16 Thread Jason Ekstrand
On Mon, Apr 16, 2018 at 6:45 AM, Erico Nunes wrote: > On Sun, Apr 15, 2018 at 2:30 AM, Jason Ekstrand > wrote: > > On April 14, 2018 12:43:35 Connor Abbott wrote: > > I think that it's probably impractical to use this path, and

Re: [Mesa-dev] [PATCH] nir: fix ir_binop_gequal glsl_to_nir conversion

2018-04-16 Thread Erico Nunes
On Sun, Apr 15, 2018 at 2:30 AM, Jason Ekstrand wrote: > On April 14, 2018 12:43:35 Connor Abbott wrote: > I think that it's probably impractical to use this path, and we should > probably delete it. There are just too many optimizations, e.g. in >

Re: [Mesa-dev] [PATCH] nir: fix ir_binop_gequal glsl_to_nir conversion

2018-04-14 Thread Jason Ekstrand
On April 14, 2018 12:43:35 Connor Abbott wrote: On Sat, Apr 14, 2018 at 3:39 PM, Erico Nunes wrote: On Sat, Apr 14, 2018 at 9:26 PM, Jason Ekstrand wrote: Reviewed-by: Jason Ekstrand What driver is

Re: [Mesa-dev] [PATCH] nir: fix ir_binop_gequal glsl_to_nir conversion

2018-04-14 Thread Connor Abbott
On Sat, Apr 14, 2018 at 3:39 PM, Erico Nunes wrote: > On Sat, Apr 14, 2018 at 9:26 PM, Jason Ekstrand wrote: >> Reviewed-by: Jason Ekstrand >> >> What driver is hitting this path? The !supports_ints path isn't used to my >>

Re: [Mesa-dev] [PATCH] nir: fix ir_binop_gequal glsl_to_nir conversion

2018-04-14 Thread Erico Nunes
On Sat, Apr 14, 2018 at 9:26 PM, Jason Ekstrand wrote: > Reviewed-by: Jason Ekstrand > > What driver is hitting this path? The !supports_ints path isn't used to my > knowledge so if some driver has started using it, they're liable to find > more bugs

Re: [Mesa-dev] [PATCH] nir: fix ir_binop_gequal glsl_to_nir conversion

2018-04-14 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand What driver is hitting this path? The !supports_ints path isn't used to my knowledge so if some driver has started using it, they're liable to find more bugs than just this one. :-) On April 14, 2018 12:16:48 Erico Nunes