Re: [Mesa-dev] [PATCH] radeonsi: fix radeon create encoder return

[Eric Engestrom]

On Tuesday, 2018-02-27 17:43:56 -0500, boyuan.zh...@amd.com wrote:
> From: Boyuan Zhang 
> 
> Previous patch missed a "return" when trying to modify the create encoder
> function, which made the whole logic fail. Therefore, add the return back.
> 
> Signed-off-by: Boyuan Zhang 

Fixes: b38b208ff8886e799d6a2 "radeonsi:create uvd hevc enc entry"
Reviewed-by: Eric Engestrom 

> ---
>  src/gallium/drivers/radeonsi/si_uvd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gallium/drivers/radeonsi/si_uvd.c 
> b/src/gallium/drivers/radeonsi/si_uvd.c
> index 3906bbd..b6cb4cb 100644
> --- a/src/gallium/drivers/radeonsi/si_uvd.c
> +++ b/src/gallium/drivers/radeonsi/si_uvd.c
> @@ -150,7 +150,7 @@ struct pipe_video_codec *si_uvd_create_decoder(struct 
> pipe_context *context,
>  
>   if (templ->entrypoint == PIPE_VIDEO_ENTRYPOINT_ENCODE) {
>   if (vcn) {
> - radeon_create_encoder(context, templ, ctx->b.ws, 
> si_vce_get_buffer);
> + return radeon_create_encoder(context, templ, ctx->b.ws, 
> si_vce_get_buffer);
>   } else {
>   if (u_reduce_video_profile(templ->profile) == 
> PIPE_VIDEO_FORMAT_HEVC)
>   return radeon_uvd_create_encoder(context, 
> templ, ctx->b.ws, si_vce_get_buffer);
> -- 
> 2.7.4
> 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] radeonsi: fix radeon create encoder return

[Alex Deucher]

On Tue, Feb 27, 2018 at 5:43 PM,   wrote:
> From: Boyuan Zhang 
>
> Previous patch missed a "return" when trying to modify the create encoder
> function, which made the whole logic fail. Therefore, add the return back.
>
> Signed-off-by: Boyuan Zhang 

Reviewed-by: Alex Deucher 

> ---
>  src/gallium/drivers/radeonsi/si_uvd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_uvd.c 
> b/src/gallium/drivers/radeonsi/si_uvd.c
> index 3906bbd..b6cb4cb 100644
> --- a/src/gallium/drivers/radeonsi/si_uvd.c
> +++ b/src/gallium/drivers/radeonsi/si_uvd.c
> @@ -150,7 +150,7 @@ struct pipe_video_codec *si_uvd_create_decoder(struct 
> pipe_context *context,
>
> if (templ->entrypoint == PIPE_VIDEO_ENTRYPOINT_ENCODE) {
> if (vcn) {
> -   radeon_create_encoder(context, templ, ctx->b.ws, 
> si_vce_get_buffer);
> +   return radeon_create_encoder(context, templ, 
> ctx->b.ws, si_vce_get_buffer);
> } else {
> if (u_reduce_video_profile(templ->profile) == 
> PIPE_VIDEO_FORMAT_HEVC)
> return radeon_uvd_create_encoder(context, 
> templ, ctx->b.ws, si_vce_get_buffer);
> --
> 2.7.4
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev