Re: [Mesa-dev] [PATCH] radv: Fix CmdCopyImage between uncompressed and compressed images

2018-03-14 Thread Alex Smith 
On 13 March 2018 at 19:14, Dave Airlie  wrote:

> On 13 March 2018 at 01:38, Alex Smith  wrote:
> > From the spec:
> >
> > "When copying between compressed and uncompressed formats the
> >  extent members represent the texel dimensions of the source
> >  image and not the destination."
> >
> > However, as per 7b890a36, we must still use the destination image type
> > when clamping the extent so that we copy the correct number of layers
> > for 2D to 3D copies.
> >
> > Fixes: 7b890a36 "radv: Fix vkCmdCopyImage for 2d slices into 3d Images"
> > Cc: 
> > Signed-off-by: Alex Smith 
>
> Reviewed-by: Dave Airlie 
>
> Might be worth filing a cts issue to see if someone wants to write
> tests for this sort of hole.
>

Thanks, pushed. CTS issue filed:
https://github.com/KhronosGroup/VK-GL-CTS/issues/90


>
> Dave.
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] radv: Fix CmdCopyImage between uncompressed and compressed images

2018-03-13 Thread Dave Airlie 
On 13 March 2018 at 01:38, Alex Smith  wrote:
> From the spec:
>
> "When copying between compressed and uncompressed formats the
>  extent members represent the texel dimensions of the source
>  image and not the destination."
>
> However, as per 7b890a36, we must still use the destination image type
> when clamping the extent so that we copy the correct number of layers
> for 2D to 3D copies.
>
> Fixes: 7b890a36 "radv: Fix vkCmdCopyImage for 2d slices into 3d Images"
> Cc: 
> Signed-off-by: Alex Smith 

Reviewed-by: Dave Airlie 

Might be worth filing a cts issue to see if someone wants to write
tests for this sort of hole.

Dave.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev