Re: [Mesa-dev] [PATCH] radv: advertise 8 bits of subpixel precision for viewports

2018-04-23 Thread Samuel Pitoiset 



On 04/23/2018 11:12 AM, Józef Kucia wrote:

On Wed, Apr 11, 2018 at 10:38 AM, Samuel Pitoiset
 wrote:

Agreed.

Reviewed-by: Samuel Pitoiset 


Please push the patch for me. I don't have commit access.


Pushed!




___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] radv: advertise 8 bits of subpixel precision for viewports

2018-04-23 Thread Józef Kucia 
On Wed, Apr 11, 2018 at 10:38 AM, Samuel Pitoiset
 wrote:
> Agreed.
>
> Reviewed-by: Samuel Pitoiset 

Please push the patch for me. I don't have commit access.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] radv: advertise 8 bits of subpixel precision for viewports

2018-04-11 Thread Samuel Pitoiset 

Agreed.

Reviewed-by: Samuel Pitoiset 

On 04/11/2018 12:11 AM, Józef Kucia wrote:

This is what radeonsi does.
---
  src/amd/vulkan/radv_device.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 4fc7392e65e6..35b686ab7f02 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -831,7 +831,7 @@ void radv_GetPhysicalDeviceProperties(
.maxViewports = MAX_VIEWPORTS,
.maxViewportDimensions= { (1 << 14), (1 << 
14) },
.viewportBoundsRange  = { INT16_MIN, 
INT16_MAX },
-   .viewportSubPixelBits = 13, /* We take a 
float? */
+   .viewportSubPixelBits = 8,
.minMemoryMapAlignment= 4096, /* A page */
.minTexelBufferOffsetAlignment= 1,
.minUniformBufferOffsetAlignment  = 4,


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev