Re: [Mesa-dev] [PATCH] spirv: Fix building with SCons

On March 30, 2018 09:40:13 Brian Paul wrote: OK, I'll have some patches soon but I'm stuck on one issue. Around spriv_to_nir.c:2090 we have if (operands & SpvImageOperandsConstOffsetsMask) { gather_offsets = vtn_ssa_value(b, w[idx++]); (*p++) = (nir_tex_src){}; } The

Re: [Mesa-dev] [PATCH] spirv: Fix building with SCons

OK, I just posted a series of patches which seems to fix everything on Windows/MSVC. Neil, I added fixes for the osmesa and libgl-gdi targets to your patch. -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] spirv: Fix building with SCons

On Fri, Mar 30, 2018 at 12:40 PM, Brian Paul wrote: > OK, I'll have some patches soon but I'm stuck on one issue. > > Around spriv_to_nir.c:2090 we have > > if (operands & SpvImageOperandsConstOffsetsMask) { > gather_offsets = vtn_ssa_value(b, w[idx++]); >

Re: [Mesa-dev] [PATCH] spirv: Fix building with SCons

On 03/30/2018 10:40 AM, Brian Paul wrote: OK, I'll have some patches soon but I'm stuck on one issue. Around spriv_to_nir.c:2090 we have   if (operands & SpvImageOperandsConstOffsetsMask) { gather_offsets = vtn_ssa_value(b, w[idx++]); (*p++) = (nir_tex_src){};   }

Re: [Mesa-dev] [PATCH] spirv: Fix building with SCons

OK, I'll have some patches soon but I'm stuck on one issue. Around spriv_to_nir.c:2090 we have if (operands & SpvImageOperandsConstOffsetsMask) { gather_offsets = vtn_ssa_value(b, w[idx++]); (*p++) = (nir_tex_src){}; } The (nir_tex_src){} expression is not valid

Re: [Mesa-dev] [PATCH] spirv: Fix building with SCons

Thanks, Neil. This fixes the SCons build on Linux, but on Windows there's a whole bunch of other issues: c:\users\brian\projects\mesa\src\compiler\spirv\vtn_private.h(232): error C2085: 'vtn_instruction_handler': not in formal parameter list