Re: [Mesa-dev] [PATCH] svga: fix blending regression

2018-03-02 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, February 28, 2018 7:29 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] svga: fix blending regression The earlier Mesa commit 3d06c8afb5 ("st/mesa: don't tr

Re: [Mesa-dev] [PATCH] svga: fix blending regression

2018-03-01 Thread Brian Paul
Piglit fbo-drawbuffers2-blend -Brian On 03/01/2018 10:25 AM, Ilia Mirkin wrote: Ok. Is there a test that failed? I'll probably have to fix up nv50 for it. On Mar 1, 2018 11:43 AM, "Brian Paul" > wrote: On 02/28/2018 08:36 AM, Ilia Mirkin wrote: Can st/m

Re: [Mesa-dev] [PATCH] svga: fix blending regression

2018-03-01 Thread Ilia Mirkin
Ok. Is there a test that failed? I'll probably have to fix up nv50 for it. On Mar 1, 2018 11:43 AM, "Brian Paul" wrote: > On 02/28/2018 08:36 AM, Ilia Mirkin wrote: > >> Can st/mesa instead be fixed to maintain the original API? Other >> drivers look in rt[0] in the non-independent_blend_enable

Re: [Mesa-dev] [PATCH] svga: fix blending regression

2018-03-01 Thread Brian Paul
On 02/28/2018 08:36 AM, Ilia Mirkin wrote: Can st/mesa instead be fixed to maintain the original API? Other drivers look in rt[0] in the non-independent_blend_enable case. For example, freedreno and nouveau. If independent blend is not in use, then rt[0] will have all the blending info, as bef

Re: [Mesa-dev] [PATCH] svga: fix blending regression

2018-02-28 Thread Ilia Mirkin
Can st/mesa instead be fixed to maintain the original API? Other drivers look in rt[0] in the non-independent_blend_enable case. For example, freedreno and nouveau. On Wed, Feb 28, 2018 at 10:29 AM, Brian Paul wrote: > The earlier Mesa commit 3d06c8afb5 ("st/mesa: don't translate blend > state wh