Re: [Mesa-dev] [PATCH 0/9] gallium/tgsi: 64-bit integer foundations

2016-09-19 Thread Nicolai Hähnle

On 16.09.2016 19:19, Ian Romanick wrote:

On 09/16/2016 06:48 AM, Nicolai Hähnle wrote:

Hi all,

this is really Dave's work, with a few touch-ups from me that I think make
sense. I've kept those separate with the intention to squash. I'd like to
land these in master even before the main ARB_gpu_shader_int64 stuff lands
(that is currently in Ian's court).


If you guys are comfortable enabling it in radeonsi, I think the rest of
the code is close enough to ready to land.  I'm sure that we'll find
more bugs as more tests become available, but that's always the case.
I've updated my arb_gpu_shader_int64 tree, but it's intertwined with
some other stuff.  I can de-tangle it easy enough.


It makes sense to re-test with whatever additional test coverage you've 
come up with by now. Although I suppose the next release is far enough 
off that there's plenty of time to fix things up.


Cheers,
Nicolai




The reason is that radeonsi's ARB_query_buffer_object support needs 64-bit
integers in shaders, and for that it's convenient to have all the TGSI
opcodes and gallivm bits in place already.

Any objections? Reviews?
Thanks,
Nicolai

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev




___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 0/9] gallium/tgsi: 64-bit integer foundations

2016-09-16 Thread Ian Romanick
On 09/16/2016 06:48 AM, Nicolai Hähnle wrote:
> Hi all,
> 
> this is really Dave's work, with a few touch-ups from me that I think make
> sense. I've kept those separate with the intention to squash. I'd like to
> land these in master even before the main ARB_gpu_shader_int64 stuff lands
> (that is currently in Ian's court).

If you guys are comfortable enabling it in radeonsi, I think the rest of
the code is close enough to ready to land.  I'm sure that we'll find
more bugs as more tests become available, but that's always the case.
I've updated my arb_gpu_shader_int64 tree, but it's intertwined with
some other stuff.  I can de-tangle it easy enough.

> The reason is that radeonsi's ARB_query_buffer_object support needs 64-bit
> integers in shaders, and for that it's convenient to have all the TGSI
> opcodes and gallivm bits in place already.
> 
> Any objections? Reviews?
> Thanks,
> Nicolai
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev