Re: [Mesa-dev] [PATCH 01/17] intel: Add a preliminary device for Ice Lake

2018-02-27 Thread Kenneth Graunke
On Tuesday, February 20, 2018 9:15:08 PM PST Matt Turner wrote: > From: Anuj Phogat > > Signed-off-by: Anuj Phogat [...] > + .urb = { \ > + .size = 1024, \ > + } This

Re: [Mesa-dev] [PATCH 01/17] intel: Add a preliminary device for Ice Lake

2018-02-21 Thread Anuj Phogat
On Wed, Feb 21, 2018 at 11:04 AM, Matt Turner wrote: > On Wed, Feb 21, 2018 at 10:37 AM, Anuj Phogat wrote: >> On Wed, Feb 21, 2018 at 9:22 AM, Rafael Antognolli >> wrote: >>> My understanding is that this commit is enough

Re: [Mesa-dev] [PATCH 01/17] intel: Add a preliminary device for Ice Lake

2018-02-21 Thread Anuj Phogat
On Wed, Feb 21, 2018 at 9:22 AM, Rafael Antognolli wrote: > My understanding is that this commit is enough to make the driver try to > initialize, at least for i965. If that's the case, how about we add > something like what was removed by commit >

Re: [Mesa-dev] [PATCH 01/17] intel: Add a preliminary device for Ice Lake

2018-02-21 Thread Matt Turner
On Wed, Feb 21, 2018 at 10:37 AM, Anuj Phogat wrote: > On Wed, Feb 21, 2018 at 9:22 AM, Rafael Antognolli > wrote: >> My understanding is that this commit is enough to make the driver try to >> initialize, at least for i965. If that's the case,

Re: [Mesa-dev] [PATCH 01/17] intel: Add a preliminary device for Ice Lake

2018-02-21 Thread Anuj Phogat
On Wed, Feb 21, 2018 at 11:09 AM, Scott D Phillips wrote: > Anuj Phogat writes: > >> On Wed, Feb 21, 2018 at 10:00 AM, Scott D Phillips >> wrote: >>> Matt Turner writes: >>> From: Anuj

Re: [Mesa-dev] [PATCH 01/17] intel: Add a preliminary device for Ice Lake

2018-02-21 Thread Scott D Phillips
Anuj Phogat writes: > On Wed, Feb 21, 2018 at 10:00 AM, Scott D Phillips > wrote: >> Matt Turner writes: >> >>> From: Anuj Phogat >>> >>> Signed-off-by: Anuj Phogat >>> ---

Re: [Mesa-dev] [PATCH 01/17] intel: Add a preliminary device for Ice Lake

2018-02-21 Thread Anuj Phogat
On Wed, Feb 21, 2018 at 10:00 AM, Scott D Phillips wrote: > Matt Turner writes: > >> From: Anuj Phogat >> >> Signed-off-by: Anuj Phogat >> --- >> include/pci_ids/i965_pci_ids.h | 9 ++ >>

Re: [Mesa-dev] [PATCH 01/17] intel: Add a preliminary device for Ice Lake

2018-02-21 Thread Scott D Phillips
Matt Turner writes: > From: Anuj Phogat > > Signed-off-by: Anuj Phogat > --- > include/pci_ids/i965_pci_ids.h | 9 ++ > src/intel/common/gen_device_info.c | 56 > +- > 2 files

Re: [Mesa-dev] [PATCH 01/17] intel: Add a preliminary device for Ice Lake

2018-02-21 Thread Matt Turner
On Wed, Feb 21, 2018 at 9:22 AM, Rafael Antognolli wrote: > My understanding is that this commit is enough to make the driver try to > initialize, at least for i965. If that's the case, how about we add > something like what was removed by commit >

Re: [Mesa-dev] [PATCH 01/17] intel: Add a preliminary device for Ice Lake

2018-02-21 Thread Rafael Antognolli
My understanding is that this commit is enough to make the driver try to initialize, at least for i965. If that's the case, how about we add something like what was removed by commit bf1577fe0972ae910c071743dc89d261a46c2926 for CNL? It could be either in this commit, or in a commit that precedes