Re: [Mesa-dev] [PATCH 1/2] gallium: Moving X11 dependencies under HAVE_PLATFORM_X11
On 13 January 2017 at 13:19, Christian König wrote: > Am 29.11.2016 um 13:22 schrieb Emil Velikov: >> >> On 28 November 2016 at 14:51, Christian König >> wrote: >> >>> --- a/src/gallium/state_trackers/va/context.c >>> +++ b/src/gallium/state_trackers/va/context.c >>> @@ -118,6 +118,7 @@ VA_DRIVER_INIT_FUNC(VADriverContextP ctx) >>> return VA_STATUS_ERROR_UNIMPLEMENTED; >>> case VA_DISPLAY_GLX: >>> case VA_DISPLAY_X11: >>> +#if defined(HAVE_PLATFORM_X11) >>> #if defined(HAVE_DRI3) >>> drv->vscreen = vl_dri3_screen_create(ctx->native_dpy, >>> ctx->x11_screen); >>> #endif >>> @@ -125,6 +126,7 @@ VA_DRIVER_INIT_FUNC(VADriverContextP ctx) >>>drv->vscreen = vl_dri2_screen_create(ctx->native_dpy, >>> ctx->x11_screen); >>> if (!drv->vscreen) >>>goto error_screen; >>> +#endif >> >> As mentioned off-list we want an #else return >> VA_STATUS_ERROR_UNIMPLEMENTED; here. >> >> I've added that locally and noticed that the patch (as-is) causes >> breakage. I have a WIP that unwraps the --with-egl-platform, fixing >> Vulkan implementations along the way. >> I should have that finished later on today. > > > Sorry for coming back to this thread after nearly two month, but I had to > take some involuntary time of. > > Did you had the chance to fix all this and if yes how we should proceed with > st/va? > As-is this is a band-aid with nasty side-effects. The "Enable --with-platforms for all" series addresses things fully, but I need to retest and send out v2. Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 1/2] gallium: Moving X11 dependencies under HAVE_PLATFORM_X11
Am 29.11.2016 um 13:22 schrieb Emil Velikov: On 28 November 2016 at 14:51, Christian König wrote: --- a/src/gallium/state_trackers/va/context.c +++ b/src/gallium/state_trackers/va/context.c @@ -118,6 +118,7 @@ VA_DRIVER_INIT_FUNC(VADriverContextP ctx) return VA_STATUS_ERROR_UNIMPLEMENTED; case VA_DISPLAY_GLX: case VA_DISPLAY_X11: +#if defined(HAVE_PLATFORM_X11) #if defined(HAVE_DRI3) drv->vscreen = vl_dri3_screen_create(ctx->native_dpy, ctx->x11_screen); #endif @@ -125,6 +126,7 @@ VA_DRIVER_INIT_FUNC(VADriverContextP ctx) drv->vscreen = vl_dri2_screen_create(ctx->native_dpy, ctx->x11_screen); if (!drv->vscreen) goto error_screen; +#endif As mentioned off-list we want an #else return VA_STATUS_ERROR_UNIMPLEMENTED; here. I've added that locally and noticed that the patch (as-is) causes breakage. I have a WIP that unwraps the --with-egl-platform, fixing Vulkan implementations along the way. I should have that finished later on today. Sorry for coming back to this thread after nearly two month, but I had to take some involuntary time of. Did you had the chance to fix all this and if yes how we should proceed with st/va? Regards, Christian. Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 1/2] gallium: Moving X11 dependencies under HAVE_PLATFORM_X11
On 28 November 2016 at 14:51, Christian König wrote: > --- a/src/gallium/state_trackers/va/context.c > +++ b/src/gallium/state_trackers/va/context.c > @@ -118,6 +118,7 @@ VA_DRIVER_INIT_FUNC(VADriverContextP ctx) >return VA_STATUS_ERROR_UNIMPLEMENTED; > case VA_DISPLAY_GLX: > case VA_DISPLAY_X11: > +#if defined(HAVE_PLATFORM_X11) > #if defined(HAVE_DRI3) >drv->vscreen = vl_dri3_screen_create(ctx->native_dpy, ctx->x11_screen); > #endif > @@ -125,6 +126,7 @@ VA_DRIVER_INIT_FUNC(VADriverContextP ctx) > drv->vscreen = vl_dri2_screen_create(ctx->native_dpy, > ctx->x11_screen); >if (!drv->vscreen) > goto error_screen; > +#endif As mentioned off-list we want an #else return VA_STATUS_ERROR_UNIMPLEMENTED; here. I've added that locally and noticed that the patch (as-is) causes breakage. I have a WIP that unwraps the --with-egl-platform, fixing Vulkan implementations along the way. I should have that finished later on today. Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
