Re: [Mesa-dev] [PATCH 1/2] mesa: GL_EXT_texture_norm16 extension plumbing

2018-04-18 Thread Tapani Pälli
On 17.04.2018 21:11, Ilia Mirkin wrote: On Tue, Apr 17, 2018 at 1:52 PM, Ian Romanick wrote: On 04/17/2018 05:19 AM, Ilia Mirkin wrote: On Mon, Apr 16, 2018 at 11:22 PM, Tapani Pälli wrote: On 17.04.2018 02:42, Ilia Mirkin wrote:

Re: [Mesa-dev] [PATCH 1/2] mesa: GL_EXT_texture_norm16 extension plumbing

2018-04-17 Thread Ilia Mirkin
On Tue, Apr 17, 2018 at 1:52 PM, Ian Romanick wrote: > On 04/17/2018 05:19 AM, Ilia Mirkin wrote: >> On Mon, Apr 16, 2018 at 11:22 PM, Tapani Pälli >> wrote: >>> On 17.04.2018 02:42, Ilia Mirkin wrote: differentiating the case "have

Re: [Mesa-dev] [PATCH 1/2] mesa: GL_EXT_texture_norm16 extension plumbing

2018-04-17 Thread Ian Romanick
On 04/17/2018 05:19 AM, Ilia Mirkin wrote: > On Mon, Apr 16, 2018 at 11:22 PM, Tapani Pälli wrote: >> On 17.04.2018 02:42, Ilia Mirkin wrote: >>> differentiating the case "have NV_image_formats but not >>> EXT_texture_norm16"? >> >> I had a version that added another

Re: [Mesa-dev] [PATCH 1/2] mesa: GL_EXT_texture_norm16 extension plumbing

2018-04-17 Thread Ilia Mirkin
On Mon, Apr 16, 2018 at 11:22 PM, Tapani Pälli wrote: > On 17.04.2018 02:42, Ilia Mirkin wrote: > > differentiating the case "have NV_image_formats but not > > EXT_texture_norm16"? > > I had a version that added another boolean but since both of these > extensions require

Re: [Mesa-dev] [PATCH 1/2] mesa: GL_EXT_texture_norm16 extension plumbing

2018-04-16 Thread Tapani Pälli
On 17.04.2018 02:42, Ilia Mirkin wrote: On Mon, Apr 16, 2018 at 7:36 PM, Tapani Pälli wrote: Hi; On 16.04.2018 18:19, Ilia Mirkin wrote: You never check EXT_texture_norm16 anywhere... is that right? Should probably respect that in the _mesa_is_es3_* helpers. Also

Re: [Mesa-dev] [PATCH 1/2] mesa: GL_EXT_texture_norm16 extension plumbing

2018-04-16 Thread Ilia Mirkin
On Mon, Apr 16, 2018 at 7:36 PM, Tapani Pälli wrote: > Hi; > > On 16.04.2018 18:19, Ilia Mirkin wrote: >> >> You never check EXT_texture_norm16 anywhere... is that right? Should >> probably respect that in the _mesa_is_es3_* helpers. Also what about > > > Oops that is very

Re: [Mesa-dev] [PATCH 1/2] mesa: GL_EXT_texture_norm16 extension plumbing

2018-04-16 Thread Tapani Pälli
Hi; On 16.04.2018 18:19, Ilia Mirkin wrote: You never check EXT_texture_norm16 anywhere... is that right? Should probably respect that in the _mesa_is_es3_* helpers. Also what about Oops that is very correct, will add the checks. shader support? I see no mention in the spec that these

Re: [Mesa-dev] [PATCH 1/2] mesa: GL_EXT_texture_norm16 extension plumbing

2018-04-16 Thread Ilia Mirkin
You never check EXT_texture_norm16 anywhere... is that right? Should probably respect that in the _mesa_is_es3_* helpers. Also what about shader support? I see no mention in the spec that these should be usable as images, except with NV_image_formats is enabled. You're just exposing them no matter