Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-12-03 Thread Ian Romanick
On 11/29/2018 07:47 AM, Connor Abbott wrote: > On Thu, Nov 29, 2018 at 4:22 PM Jason Ekstrand wrote: >> >> Can you provide some context for this? Those rules are already flagged >> "inexact" (that's what the ~ means) so they won't apply to anything that's >> "precise" or "invariant". > > I

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-12-03 Thread Ian Romanick
On 12/01/2018 05:58 AM, Connor Abbott wrote: > On Fri, Nov 30, 2018 at 10:18 PM Ian Romanick wrote: >> >> On 11/29/2018 07:47 AM, Connor Abbott wrote: >>> On Thu, Nov 29, 2018 at 4:22 PM Jason Ekstrand wrote: Can you provide some context for this? Those rules are already flagged

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-12-01 Thread Samuel Pitoiset
On 12/1/18 3:36 PM, Connor Abbott wrote: On Sat, Dec 1, 2018 at 3:22 PM Samuel Pitoiset wrote: I'm not saying this series is the right thing to do. It just fixes two test failures in the vkd3d testsuite for RADV. I added a new compiler option to not break anything and to only affects RADV.

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-12-01 Thread Connor Abbott
On Sat, Dec 1, 2018 at 3:22 PM Samuel Pitoiset wrote: > > I'm not saying this series is the right thing to do. It just fixes two > test failures in the vkd3d testsuite for RADV. I added a new compiler > option to not break anything and to only affects RADV. Anyways, it seems > unclear what the

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-12-01 Thread Samuel Pitoiset
I'm not saying this series is the right thing to do. It just fixes two test failures in the vkd3d testsuite for RADV. I added a new compiler option to not break anything and to only affects RADV. Anyways, it seems unclear what the best option is. To sum up, looks like there is 3 ways: 1) set

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-12-01 Thread Connor Abbott
On Fri, Nov 30, 2018 at 10:18 PM Ian Romanick wrote: > > On 11/29/2018 07:47 AM, Connor Abbott wrote: > > On Thu, Nov 29, 2018 at 4:22 PM Jason Ekstrand wrote: > >> > >> Can you provide some context for this? Those rules are already flagged > >> "inexact" (that's what the ~ means) so they

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-11-30 Thread Ian Romanick
On 11/30/2018 02:36 PM, Jason Ekstrand wrote: > On Fri, Nov 30, 2018 at 4:34 PM Ian Romanick > wrote: > > On 11/30/2018 01:29 PM, Jason Ekstrand wrote: > > On Fri, Nov 30, 2018 at 3:18 PM Ian Romanick > >

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-11-30 Thread Ian Romanick
On 11/30/2018 01:36 PM, Bas Nieuwenhuizen wrote: > On Fri, Nov 30, 2018 at 10:29 PM Jason Ekstrand wrote: >> >> On Fri, Nov 30, 2018 at 3:18 PM Ian Romanick wrote: >>> >>> On 11/29/2018 07:47 AM, Connor Abbott wrote: On Thu, Nov 29, 2018 at 4:22 PM Jason Ekstrand wrote: > >

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-11-30 Thread Jason Ekstrand
On Fri, Nov 30, 2018 at 4:34 PM Ian Romanick wrote: > On 11/30/2018 01:29 PM, Jason Ekstrand wrote: > > On Fri, Nov 30, 2018 at 3:18 PM Ian Romanick > > wrote: > > > > On 11/29/2018 07:47 AM, Connor Abbott wrote: > > > On Thu, Nov 29, 2018 at 4:22 PM Jason

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-11-30 Thread Ian Romanick
On 11/30/2018 01:29 PM, Jason Ekstrand wrote: > On Fri, Nov 30, 2018 at 3:18 PM Ian Romanick > wrote: > > On 11/29/2018 07:47 AM, Connor Abbott wrote: > > On Thu, Nov 29, 2018 at 4:22 PM Jason Ekstrand > mailto:ja...@jlekstrand.net>> wrote: > >> >

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-11-30 Thread Jason Ekstrand
On Fri, Nov 30, 2018 at 3:37 PM Bas Nieuwenhuizen wrote: > On Fri, Nov 30, 2018 at 10:29 PM Jason Ekstrand > wrote: > > > > On Fri, Nov 30, 2018 at 3:18 PM Ian Romanick > wrote: > >> > >> On 11/29/2018 07:47 AM, Connor Abbott wrote: > >> > On Thu, Nov 29, 2018 at 4:22 PM Jason Ekstrand >

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-11-30 Thread Bas Nieuwenhuizen
On Fri, Nov 30, 2018 at 10:29 PM Jason Ekstrand wrote: > > On Fri, Nov 30, 2018 at 3:18 PM Ian Romanick wrote: >> >> On 11/29/2018 07:47 AM, Connor Abbott wrote: >> > On Thu, Nov 29, 2018 at 4:22 PM Jason Ekstrand >> > wrote: >> >> >> >> Can you provide some context for this? Those rules are

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-11-30 Thread Jason Ekstrand
On Fri, Nov 30, 2018 at 3:18 PM Ian Romanick wrote: > On 11/29/2018 07:47 AM, Connor Abbott wrote: > > On Thu, Nov 29, 2018 at 4:22 PM Jason Ekstrand > wrote: > >> > >> Can you provide some context for this? Those rules are already flagged > "inexact" (that's what the ~ means) so they won't

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-11-30 Thread Ian Romanick
On 11/29/2018 07:47 AM, Connor Abbott wrote: > On Thu, Nov 29, 2018 at 4:22 PM Jason Ekstrand wrote: >> >> Can you provide some context for this? Those rules are already flagged >> "inexact" (that's what the ~ means) so they won't apply to anything that's >> "precise" or "invariant". > > I

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-11-29 Thread Timothy Arceri
On Thu, Nov 29, 2018, at 7:47 AM, Connor Abbott wrote: > On Thu, Nov 29, 2018 at 4:22 PM Jason Ekstrand wrote: > > > > Can you provide some context for this? Those rules are already flagged > > "inexact" (that's what the ~ means) so they won't apply to anything that's > > "precise" or

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-11-29 Thread Connor Abbott
On Thu, Nov 29, 2018 at 4:47 PM Connor Abbott wrote: > > On Thu, Nov 29, 2018 at 4:22 PM Jason Ekstrand wrote: > > > > Can you provide some context for this? Those rules are already flagged > > "inexact" (that's what the ~ means) so they won't apply to anything that's > > "precise" or

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-11-29 Thread Connor Abbott
On Thu, Nov 29, 2018 at 4:22 PM Jason Ekstrand wrote: > > Can you provide some context for this? Those rules are already flagged > "inexact" (that's what the ~ means) so they won't apply to anything that's > "precise" or "invariant". I think the concern is that this isn't allowed in SPIR-V,

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-11-29 Thread Jason Ekstrand
Can you provide some context for this? Those rules are already flagged "inexact" (that's what the ~ means) so they won't apply to anything that's "precise" or "invariant". On Thu, Nov 29, 2018 at 9:18 AM Samuel Pitoiset wrote: > It's correct in GLSL because the behaviour is undefined in >