Re: [Mesa-dev] [PATCH 1/3] genxml/pack: Allow hex values in the XML

2017-04-20 Thread Dylan Baker 
Quoting Jason Ekstrand (2017-04-19 17:17:25)
> ---
>  src/intel/genxml/gen_pack_header.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/intel/genxml/gen_pack_header.py 
> b/src/intel/genxml/gen_pack_header.py
> index 2a70945..5b55143 100644
> --- a/src/intel/genxml/gen_pack_header.py
> +++ b/src/intel/genxml/gen_pack_header.py
> @@ -7,6 +7,7 @@ import xml.parsers.expat
>  import re
>  import sys
>  import copy
> +import ast

please sort the imports :)

with that minor nit:
Reviewed-by: Dylan Baker 

>  
>  license =  """/*
>   * Copyright (C) 2016 Intel Corporation
> @@ -476,7 +477,7 @@ class Group(object):
>  class Value(object):
>  def __init__(self, attrs):
>  self.name = safe_name(attrs["name"])
> -self.value = int(attrs["value"])
> +self.value = ast.literal_eval(attrs["value"])
>  
>  class Parser(object):
>  def __init__(self):
> -- 
> 2.5.0.400.gff86faf
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/3] genxml/pack: Allow hex values in the XML

2017-04-20 Thread Iago Toral 
All 3 patches (assuming Dylan's fine with patch 1) are:

Reviewed by: Iago Toral Quiroga 


On Wed, 2017-04-19 at 17:17 -0700, Jason Ekstrand wrote:
> ---
>  src/intel/genxml/gen_pack_header.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/intel/genxml/gen_pack_header.py
> b/src/intel/genxml/gen_pack_header.py
> index 2a70945..5b55143 100644
> --- a/src/intel/genxml/gen_pack_header.py
> +++ b/src/intel/genxml/gen_pack_header.py
> @@ -7,6 +7,7 @@ import xml.parsers.expat
>  import re
>  import sys
>  import copy
> +import ast
>  
>  license =  """/*
>   * Copyright (C) 2016 Intel Corporation
> @@ -476,7 +477,7 @@ class Group(object):
>  class Value(object):
>  def __init__(self, attrs):
>  self.name = safe_name(attrs["name"])
> -self.value = int(attrs["value"])
> +self.value = ast.literal_eval(attrs["value"])
>  
>  class Parser(object):
>  def __init__(self):
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev