Re: [Mesa-dev] [PATCH 1/4] i965: Replace fs_reg(fs_visitor, type) with fs_visitor::vgrf(type).

2015-01-16 Thread Jason Ekstrand
On Jan 16, 2015 4:19 PM, Kenneth Graunke kenn...@whitecape.org wrote: I dislike how fs_reg has a constructor that knows about fs_visitor. Apart from that, it stands alone, with no need to interact with the rest of the compiler. Which is sensible - a class that represents a register should do

Re: [Mesa-dev] [PATCH 1/4] i965: Replace fs_reg(fs_visitor, type) with fs_visitor::vgrf(type).

2015-01-16 Thread Chris Forbes
The vec4 side is similarly tangled, except there are 3 constructors like this spread across the src_reg and dst_reg classes. Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sat, Jan 17, 2015 at 11:19 AM, Kenneth Graunke kenn...@whitecape.org wrote: I dislike how fs_reg has a constructor that