Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-08 Thread Pierre Moreau
On 2018-02-08 — 12:47, Francisco Jerez wrote: > Pierre Moreau writes: > > > On 2018-02-07 — 12:36, Francisco Jerez wrote: > >> Pierre Moreau writes: > >> > >> > On 2018-02-06 — 20:50, Jan Vesely wrote: > >> > [snip] > >> >> > > Happy to here

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-08 Thread Francisco Jerez
Pierre Moreau writes: > On 2018-02-07 — 12:36, Francisco Jerez wrote: >> Pierre Moreau writes: >> >> > On 2018-02-06 — 20:50, Jan Vesely wrote: >> > [snip] >> >> > > Happy to here suggestions for solving the current conflict in uses of >> >> > >

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-08 Thread Jan Vesely
On Thu, 2018-02-08 at 10:25 +0100, Pierre Moreau wrote: > On 2018-02-07 — 12:36, Francisco Jerez wrote: > > Pierre Moreau writes: > > > > > On 2018-02-06 — 20:50, Jan Vesely wrote: > > > [snip] > > > > > > Happy to here suggestions for solving the current conflict in uses

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-08 Thread Pierre Moreau
On 2018-02-07 — 12:36, Francisco Jerez wrote: > Pierre Moreau writes: > > > On 2018-02-06 — 20:50, Jan Vesely wrote: > > [snip] > >> > > Happy to here suggestions for solving the current conflict in uses of > >> > > PIPE_SHADER_CAP_PREFERRED_IR. > >> > > >> > One option

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-07 Thread Francisco Jerez
Pierre Moreau writes: > On 2018-02-06 — 20:50, Jan Vesely wrote: > [snip] >> > > Happy to here suggestions for solving the current conflict in uses of >> > > PIPE_SHADER_CAP_PREFERRED_IR. >> > >> > One option could be to: >> > * look at the preferred IR >> > |-> if

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-07 Thread Pierre Moreau
On 2018-02-06 — 20:50, Jan Vesely wrote: [snip] > > > Happy to here suggestions for solving the current conflict in uses of > > > PIPE_SHADER_CAP_PREFERRED_IR. > > > > One option could be to: > > * look at the preferred IR > > |-> if clover supports it, use it > > |-> else, check if any IR

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-06 Thread Jan Vesely
On Fri, 2018-02-02 at 10:22 +0100, Pierre Moreau wrote: > On 2018-02-02 — 18:07, Timothy Arceri wrote: > > > > > > On 02/02/18 17:21, Timothy Arceri wrote: > > > On 02/02/18 16:38, Jan Vesely wrote: > > > > On Fri, 2018-02-02 at 15:03 +1100, Timothy Arceri wrote: > > > > > When

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-06 Thread Marek Olšák
I made a comment on patch 1. With that addressed, the series is: Reviewed-by: Marek Olšák Marek On Fri, Feb 2, 2018 at 5:03 AM, Timothy Arceri wrote: > When PIPE_SHADER_IR_LLVM existed this query made sense but now it > always returns

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-06 Thread Marek Olšák
On Fri, Feb 2, 2018 at 8:07 AM, Timothy Arceri wrote: > > > On 02/02/18 17:21, Timothy Arceri wrote: >> >> On 02/02/18 16:38, Jan Vesely wrote: >>> >>> On Fri, 2018-02-02 at 15:03 +1100, Timothy Arceri wrote: When PIPE_SHADER_IR_LLVM existed this query made sense

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-02 Thread Pierre Moreau
On 2018-02-02 — 18:07, Timothy Arceri wrote: > > > On 02/02/18 17:21, Timothy Arceri wrote: > > On 02/02/18 16:38, Jan Vesely wrote: > > > On Fri, 2018-02-02 at 15:03 +1100, Timothy Arceri wrote: > > > > When PIPE_SHADER_IR_LLVM existed this query made sense but now it > > > > always returns

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-01 Thread Timothy Arceri
On 02/02/18 17:21, Timothy Arceri wrote: On 02/02/18 16:38, Jan Vesely wrote: On Fri, 2018-02-02 at 15:03 +1100, Timothy Arceri wrote: When PIPE_SHADER_IR_LLVM existed this query made sense but now it always returns PIPE_SHADER_IR_NATIVE. Also it is now conlicting with PIPE_SHADER_IR_NIR for

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-01 Thread Timothy Arceri
On 02/02/18 16:38, Jan Vesely wrote: On Fri, 2018-02-02 at 15:03 +1100, Timothy Arceri wrote: When PIPE_SHADER_IR_LLVM existed this query made sense but now it always returns PIPE_SHADER_IR_NATIVE. Also it is now conlicting with PIPE_SHADER_IR_NIR for compute shaders, so just assume this is

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-01 Thread Jan Vesely
On Fri, 2018-02-02 at 15:03 +1100, Timothy Arceri wrote: > When PIPE_SHADER_IR_LLVM existed this query made sense but now it > always returns PIPE_SHADER_IR_NATIVE. Also it is now conlicting > with PIPE_SHADER_IR_NIR for compute shaders, so just assume this > is always PIPE_SHADER_IR_NATIVE for

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-01 Thread Timothy Arceri
On 02/02/18 15:12, Ilia Mirkin wrote: Seems like the proper solution to this problem is to use something like ST_DEBUG=nir (which would in turn check the SUPPORTED_IRS bitmap) rather than trying to hack drivers... That sounds like more of a hack to me. What happend when nir becomes the

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-01 Thread Ilia Mirkin
Seems like the proper solution to this problem is to use something like ST_DEBUG=nir (which would in turn check the SUPPORTED_IRS bitmap) rather than trying to hack drivers... On Thu, Feb 1, 2018 at 11:03 PM, Timothy Arceri wrote: > When PIPE_SHADER_IR_LLVM existed this