Re: [Mesa-dev] [PATCH 14/59] intel/compiler: lower some 16-bit float operations to 32-bit

2018-12-07 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand 

On Tue, Dec 4, 2018 at 1:18 AM Iago Toral Quiroga  wrote:

> The hardware doesn't support half-float for these.
> ---
>  src/intel/compiler/brw_nir.c | 5 +
>  1 file changed, 5 insertions(+)
>
> diff --git a/src/intel/compiler/brw_nir.c b/src/intel/compiler/brw_nir.c
> index aa6788b9fe5..e0027f5179c 100644
> --- a/src/intel/compiler/brw_nir.c
> +++ b/src/intel/compiler/brw_nir.c
> @@ -620,6 +620,11 @@ lower_bit_size_callback(const nir_alu_instr *alu,
> UNUSED void *data)
> case nir_op_irem:
> case nir_op_udiv:
> case nir_op_umod:
> +   case nir_op_fceil:
> +   case nir_op_ffloor:
> +   case nir_op_ffract:
> +   case nir_op_fround_even:
> +   case nir_op_ftrunc:
>return 32;
> default:
>return 0;
> --
> 2.17.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 14/59] intel/compiler: lower some 16-bit float operations to 32-bit

2018-12-05 Thread Pohjolainen, Topi
On Tue, Dec 04, 2018 at 08:16:38AM +0100, Iago Toral Quiroga wrote:
> The hardware doesn't support half-float for these.

Reviewed-by: Topi Pohjolainen 

> ---
>  src/intel/compiler/brw_nir.c | 5 +
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/intel/compiler/brw_nir.c b/src/intel/compiler/brw_nir.c
> index aa6788b9fe5..e0027f5179c 100644
> --- a/src/intel/compiler/brw_nir.c
> +++ b/src/intel/compiler/brw_nir.c
> @@ -620,6 +620,11 @@ lower_bit_size_callback(const nir_alu_instr *alu, UNUSED 
> void *data)
> case nir_op_irem:
> case nir_op_udiv:
> case nir_op_umod:
> +   case nir_op_fceil:
> +   case nir_op_ffloor:
> +   case nir_op_ffract:
> +   case nir_op_fround_even:
> +   case nir_op_ftrunc:
>return 32;
> default:
>return 0;
> -- 
> 2.17.1
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev