Re: [Mesa-dev] [PATCH 18/22] i965/fs: Add infrastructure for generating CSEL instructions.

2018-03-06 Thread Matt Turner
On Tue, Mar 6, 2018 at 11:28 AM, Ian Romanick wrote: > On 03/06/2018 11:24 AM, Matt Turner wrote: >> On Tue, Mar 6, 2018 at 11:22 AM, Ian Romanick wrote: >>> On 03/05/2018 04:40 PM, Matt Turner wrote: On Fri, Feb 23, 2018 at 3:56 PM, Ian Romanick

Re: [Mesa-dev] [PATCH 18/22] i965/fs: Add infrastructure for generating CSEL instructions.

2018-03-06 Thread Ian Romanick
On 03/06/2018 11:24 AM, Matt Turner wrote: > On Tue, Mar 6, 2018 at 11:22 AM, Ian Romanick wrote: >> On 03/05/2018 04:40 PM, Matt Turner wrote: >>> On Fri, Feb 23, 2018 at 3:56 PM, Ian Romanick wrote: From: Kenneth Graunke

Re: [Mesa-dev] [PATCH 18/22] i965/fs: Add infrastructure for generating CSEL instructions.

2018-03-06 Thread Matt Turner
On Tue, Mar 6, 2018 at 11:22 AM, Ian Romanick wrote: > On 03/05/2018 04:40 PM, Matt Turner wrote: >> On Fri, Feb 23, 2018 at 3:56 PM, Ian Romanick wrote: >>> From: Kenneth Graunke >>> >>> v2 (idr): Don't allow CSEL with a

Re: [Mesa-dev] [PATCH 18/22] i965/fs: Add infrastructure for generating CSEL instructions.

2018-03-06 Thread Ian Romanick
On 03/05/2018 04:40 PM, Matt Turner wrote: > On Fri, Feb 23, 2018 at 3:56 PM, Ian Romanick wrote: >> From: Kenneth Graunke >> >> v2 (idr): Don't allow CSEL with a non-float src2. >> >> v3 (idr): Add CSEL to fs_inst::flags_written. Suggested by Matt.

Re: [Mesa-dev] [PATCH 18/22] i965/fs: Add infrastructure for generating CSEL instructions.

2018-03-05 Thread Matt Turner
On Fri, Feb 23, 2018 at 3:56 PM, Ian Romanick wrote: > From: Kenneth Graunke > > v2 (idr): Don't allow CSEL with a non-float src2. > > v3 (idr): Add CSEL to fs_inst::flags_written. Suggested by Matt. brw_disassemble_inst fs_visitor::dump_instruction

Re: [Mesa-dev] [PATCH 18/22] i965/fs: Add infrastructure for generating CSEL instructions.

2018-03-05 Thread Matt Turner
On Fri, Feb 23, 2018 at 3:56 PM, Ian Romanick wrote: > From: Kenneth Graunke > > v2 (idr): Don't allow CSEL with a non-float src2. > > v3 (idr): Add CSEL to fs_inst::flags_written. Suggested by Matt. > > Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH 18/22] i965/fs: Add infrastructure for generating CSEL instructions.

2018-03-05 Thread Kenneth Graunke
On Monday, March 5, 2018 11:17:29 AM PST Ian Romanick wrote: > On 02/28/2018 12:58 AM, Samuel Iglesias Gonsálvez wrote: > > On 24/02/18 00:56, Ian Romanick wrote: > >> From: Kenneth Graunke > >> > >> v2 (idr): Don't allow CSEL with a non-float src2. > >> > >> v3 (idr): Add

Re: [Mesa-dev] [PATCH 18/22] i965/fs: Add infrastructure for generating CSEL instructions.

2018-03-05 Thread Ian Romanick
On 02/28/2018 12:58 AM, Samuel Iglesias Gonsálvez wrote: > On 24/02/18 00:56, Ian Romanick wrote: >> From: Kenneth Graunke >> >> v2 (idr): Don't allow CSEL with a non-float src2. >> >> v3 (idr): Add CSEL to fs_inst::flags_written. Suggested by Matt. >> >> Signed-off-by:

Re: [Mesa-dev] [PATCH 18/22] i965/fs: Add infrastructure for generating CSEL instructions.

2018-02-28 Thread Samuel Iglesias Gonsálvez
On 24/02/18 00:56, Ian Romanick wrote: > From: Kenneth Graunke > > v2 (idr): Don't allow CSEL with a non-float src2. > > v3 (idr): Add CSEL to fs_inst::flags_written. Suggested by Matt. > > Signed-off-by: Kenneth Graunke > Signed-off-by: Ian