Re: [Mesa-dev] [PATCH 2/2] radv/winsys: Fix radv_amdgpu_cs_grow min_size argument. (v2)

2016-10-12 Thread Bas Nieuwenhuizen
On Mon, Oct 10, 2016 at 9:19 PM, Gustaw Smolarczyk wrote: > 2016-10-10 22:04 GMT+02:00 Bas Nieuwenhuizen : >> Hi Gustaw, >> >> The patch is >> reviewed-by: Bas Nieuwenhuizen > > Thanks, please push it since I don't have commit access. > >> >> What needs to be done too, is checking if the resulti

Re: [Mesa-dev] [PATCH 2/2] radv/winsys: Fix radv_amdgpu_cs_grow min_size argument. (v2)

2016-10-10 Thread Gustaw Smolarczyk
2016-10-10 22:04 GMT+02:00 Bas Nieuwenhuizen : > Hi Gustaw, > > The patch is > reviewed-by: Bas Nieuwenhuizen Thanks, please push it since I don't have commit access. > > What needs to be done too, is checking if the resulting IB becomes too > large in the SI case, and handling that gracefully.

Re: [Mesa-dev] [PATCH 2/2] radv/winsys: Fix radv_amdgpu_cs_grow min_size argument. (v2)

2016-10-10 Thread Bas Nieuwenhuizen
Hi Gustaw, The patch is reviewed-by: Bas Nieuwenhuizen What needs to be done too, is checking if the resulting IB becomes too large in the SI case, and handling that gracefully. I don't care if that happens with this patch, or if someone writes a follow up patch though Yours sincerely, Bas Nieu

Re: [Mesa-dev] [PATCH 2/2] radv/winsys: Fix radv_amdgpu_cs_grow min_size argument. (v2)

2016-10-10 Thread Gustaw Smolarczyk
Ping. 2016-10-06 19:50 GMT+02:00 Gustaw Smolarczyk : > It's supposed to be how much at least we want to grow the cs, not the > minimum size of the cs after growth. > > v2: Unbreak use_ib_bos. > Don't mask the ib_size when !use_ib_bos, since it's not needed. > --- > src/amd/vulkan/winsys/amdgp