Re: [Mesa-dev] [PATCH 2/5] amd/addrlib: hide private symbols via VISIBILITY_CXXFLAGS

2016-10-12 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Oct 12, 2016 at 8:05 PM, Emil Velikov wrote: > From: Emil Velikov > > Private/internal symbols should never not be exported. Using the > CXXFLAGS cuts ~300 exported symbols and ~23K from libvulkan_radeon.so. > > Signed-off-by: Emil Velikov > --- > src/a

Re: [Mesa-dev] [PATCH 2/5] amd/addrlib: hide private symbols via VISIBILITY_CXXFLAGS

2016-10-12 Thread Emil Velikov
On 12 October 2016 at 20:28, Bas Nieuwenhuizen wrote: > On Wed, Oct 12, 2016 at 7:05 PM, Emil Velikov > wrote: >> From: Emil Velikov >> >> Private/internal symbols should never not be exported. Using the >> CXXFLAGS cuts ~300 exported symbols and ~23K from libvulkan_radeon.so. > > Double negati

Re: [Mesa-dev] [PATCH 2/5] amd/addrlib: hide private symbols via VISIBILITY_CXXFLAGS

2016-10-12 Thread Bas Nieuwenhuizen
On Wed, Oct 12, 2016 at 7:05 PM, Emil Velikov wrote: > From: Emil Velikov > > Private/internal symbols should never not be exported. Using the > CXXFLAGS cuts ~300 exported symbols and ~23K from libvulkan_radeon.so. Double negative? I think the message is much more consistent with single negativ