Re: [Mesa-dev] [PATCH 2/5] amd/addrlib: hide private symbols via VISIBILITY_CXXFLAGS

2016-10-12 Thread Marek Olšák 
Reviewed-by: Marek Olšák 

Marek

On Wed, Oct 12, 2016 at 8:05 PM, Emil Velikov  wrote:
> From: Emil Velikov 
>
> Private/internal symbols should never not be exported. Using the
> CXXFLAGS cuts ~300 exported symbols and ~23K from libvulkan_radeon.so.
>
> Signed-off-by: Emil Velikov 
> ---
>  src/amd/Makefile.addrlib.am | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/amd/Makefile.addrlib.am b/src/amd/Makefile.addrlib.am
> index 434e692..64823fc 100644
> --- a/src/amd/Makefile.addrlib.am
> +++ b/src/amd/Makefile.addrlib.am
> @@ -30,6 +30,9 @@ addrlib_libamdgpu_addrlib_la_CPPFLAGS = \
> -I$(srcdir)/addrlib/r800/chip \
> -DBRAHMA_BUILD=1
>
> +addrlib_libamdgpu_addrlib_la_CXXFLAGS = \
> +   $(VISIBILITY_CXXFLAGS)
> +
>  noinst_LTLIBRARIES += $(ADDRLIB_LIBS)
>
>  addrlib_libamdgpu_addrlib_la_SOURCES = $(ADDRLIB_FILES)
> --
> 2.10.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/5] amd/addrlib: hide private symbols via VISIBILITY_CXXFLAGS

2016-10-12 Thread Emil Velikov 
On 12 October 2016 at 20:28, Bas Nieuwenhuizen  wrote:
> On Wed, Oct 12, 2016 at 7:05 PM, Emil Velikov  
> wrote:
>> From: Emil Velikov 
>>
>> Private/internal symbols should never not be exported. Using the
>> CXXFLAGS cuts ~300 exported symbols and ~23K from libvulkan_radeon.so.
>
> Double negative? I think the message is much more consistent with
> single negative. With that, patch 2-5 are
>
> Acked-by: Bas Nieuwenhuizen 
>
Hmm nicely spotted. Guess there's no need to explain that double
"negatives" behave differently in other languages ;-)

Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/5] amd/addrlib: hide private symbols via VISIBILITY_CXXFLAGS

2016-10-12 Thread Bas Nieuwenhuizen 
On Wed, Oct 12, 2016 at 7:05 PM, Emil Velikov  wrote:
> From: Emil Velikov 
>
> Private/internal symbols should never not be exported. Using the
> CXXFLAGS cuts ~300 exported symbols and ~23K from libvulkan_radeon.so.

Double negative? I think the message is much more consistent with
single negative. With that, patch 2-5 are

Acked-by: Bas Nieuwenhuizen 

>
> Signed-off-by: Emil Velikov 
> ---
>  src/amd/Makefile.addrlib.am | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/amd/Makefile.addrlib.am b/src/amd/Makefile.addrlib.am
> index 434e692..64823fc 100644
> --- a/src/amd/Makefile.addrlib.am
> +++ b/src/amd/Makefile.addrlib.am
> @@ -30,6 +30,9 @@ addrlib_libamdgpu_addrlib_la_CPPFLAGS = \
> -I$(srcdir)/addrlib/r800/chip \
> -DBRAHMA_BUILD=1
>
> +addrlib_libamdgpu_addrlib_la_CXXFLAGS = \
> +   $(VISIBILITY_CXXFLAGS)
> +
>  noinst_LTLIBRARIES += $(ADDRLIB_LIBS)
>
>  addrlib_libamdgpu_addrlib_la_SOURCES = $(ADDRLIB_FILES)
> --
> 2.10.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev