Re: [Mesa-dev] [PATCH 2/5] nvc0/ir: use levelZero flag when the lod is set to 0

2016-10-22 Thread Ilia Mirkin
Right, so arg+1, -1 is the right thing. However, this patch is bogus. It relies on getImmediate which in turn relies on getUniqueInsn, which in turn doesn't work pre-ssa (except in very contrived scenarios). So I'm going to try to put together a series that resolves many of these things, like

Re: [Mesa-dev] [PATCH 2/5] nvc0/ir: use levelZero flag when the lod is set to 0

2016-10-21 Thread Ilia Mirkin
Yeah, it might actually need to be arg+1, -1. I didn't test this patch too thoroughly... On Fri, Oct 21, 2016 at 9:53 AM, Samuel Pitoiset wrote: > This patch breaks a bunch of piglit tests, see a short list below: > > bin/arb_texture_barrier-blending-in-shader 512 42 1

Re: [Mesa-dev] [PATCH 2/5] nvc0/ir: use levelZero flag when the lod is set to 0

2016-10-21 Thread Samuel Pitoiset
This patch breaks a bunch of piglit tests, see a short list below: bin/arb_texture_barrier-blending-in-shader 512 42 1 128 7 -auto -fbo bin/arb_texture_buffer_object-formats vs core -auto -fbo bin/texelFetch 140 vs sampler2DRect -auto -fbo bin/mesa_pack_invert-readpixels -auto -fbo ... Around

Re: [Mesa-dev] [PATCH 2/5] nvc0/ir: use levelZero flag when the lod is set to 0

2016-10-21 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 10/21/2016 08:30 AM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 9 + 1 file changed, 9 insertions(+) diff --git