Re: [Mesa-dev] [PATCH 3/4] glsl: Remove unused function import_prototypes

2016-10-14 Thread Timothy Arceri 


On 15 October 2016 10:11:17 am AEDT, Kenneth Graunke  
wrote:
>On Friday, October 14, 2016 11:59:46 AM PDT Ian Romanick wrote:
>> From: Ian Romanick 
>> 
>> Once upon a time, this was used to extract prototypes from the shader
>> containing GLSL built-in functions.  This was removed by f5692f45 in
>> November 2010 for Mesa 7.10.
>> 
>> Signed-off-by: Ian Romanick 
>> Cc: Kenneth Graunke 
>
>Dead for 6 years, and we only now noticed...derp. :)  I wish there were
>better compiler warnings for things like this...

LibreOffice uses this [1]. Note the todo to make it a gcc plugin but I don't 
think there has been any progress towards that.

[1] http://www.skynet.ie/~caolan/Packages/callcatcher.html

>
>Series is:
>Reviewed-by: Kenneth Graunke 
>
>
>
>
>
>
>___
>mesa-dev mailing list
>mesa-dev@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/mesa-dev

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/4] glsl: Remove unused function import_prototypes

2016-10-14 Thread Kenneth Graunke 
On Friday, October 14, 2016 11:59:46 AM PDT Ian Romanick wrote:
> From: Ian Romanick 
> 
> Once upon a time, this was used to extract prototypes from the shader
> containing GLSL built-in functions.  This was removed by f5692f45 in
> November 2010 for Mesa 7.10.
> 
> Signed-off-by: Ian Romanick 
> Cc: Kenneth Graunke 

Dead for 6 years, and we only now noticed...derp. :)  I wish there were
better compiler warnings for things like this...

Series is:
Reviewed-by: Kenneth Graunke 




signature.asc
Description: This is a digitally signed message part.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev