Re: [Mesa-dev] [PATCH 4/4] scons: Make GCC builds stricter.
On 2019-08-28 1:56 p.m., Jose Fonseca wrote: > Hi Michel, > >> Good to see you guys starting to take better advantage of the >> GitLab CI pipeline. > > Gitlab CI integration is complicated (very configurable), but I can > tell from my experience with my own personal Github projects that > having tests run during PRs are a god send. Yeah. >> With my last name spelled correctly Dänzer or Daenzer, > > Oops. I worried about getting the "ae" right and forgot the "n".. > m(_ _)m No worries, I appreciate your effort! :) -- Earthling Michel Dänzer | https://redhat.com Libre software enthusiast | Mesa and X developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 4/4] scons: Make GCC builds stricter.
Hi Michel, > Good to see you guys starting to take better advantage of the GitLab CI > pipeline. Gitlab CI integration is complicated (very configurable), but I can tell from my experience with my own personal Github projects that having tests run during PRs are a god send. > With my last name spelled correctly Dänzer or Daenzer, Oops. I worried about getting the "ae" right and forgot the "n".. m(_ _)m Jose From: Michel Dänzer Sent: Wednesday, August 28, 2019 11:59 To: Jose Fonseca ; Brian Paul ; Roland Scheidegger ; Charmaine Lee Cc: mesa-dev@lists.freedesktop.org ; e...@engestrom.ch Subject: Re: [Mesa-dev] [PATCH 4/4] scons: Make GCC builds stricter. On 2019-08-27 12:57 p.m., Jose Fonseca wrote: > Uses some of the same -Werror options used by Meson, Cool stuff! Good to see you guys starting to take better advantage of the GitLab CI pipeline. > as suggested by Michel Daezer. With my last name spelled correctly Dänzer or Daenzer, Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fredhat.comdata=02%7C01%7Cjfonseca%40vmware.com%7C00a1f6d6e4524f99fd1308d72ba6d5fe%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637025867896875073sdata=FT3RG3hSCPhJe5Xdm3JIZ8gvSbjc6gbpsOIi0x3lMa4%3Dreserved=0 Libre software enthusiast | Mesa and X developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 4/4] scons: Make GCC builds stricter.
On 2019-08-27 12:57 p.m., Jose Fonseca wrote: > Uses some of the same -Werror options used by Meson, Cool stuff! Good to see you guys starting to take better advantage of the GitLab CI pipeline. > as suggested by Michel Daezer. With my last name spelled correctly Dänzer or Daenzer, Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | https://redhat.com Libre software enthusiast | Mesa and X developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 4/4] scons: Make GCC builds stricter.
Am 27.08.19 um 12:57 schrieb Jose Fonseca: > Uses some of the same -Werror options used by Meson, as suggested by > Michel Daezer. > --- > scons/gallium.py | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/scons/gallium.py b/scons/gallium.py > index 21197c8d0d1..2eff4174257 100755 > --- a/scons/gallium.py > +++ b/scons/gallium.py > @@ -473,7 +473,10 @@ def generate(env): > '-fmessage-length=0', # be nice to Eclipse > ] > cflags += [ > -'-Wmissing-prototypes', > +'-Werror=implicit-function-declaration', > +'-Werror=missing-prototypes', > +'-Werror=return-type', > +'-Werror=incompatible-pointer-types', > '-std=gnu99', > ] > if icc: > For the series: Reviewed-by: Roland Scheidegger ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 4/4] scons: Make GCC builds stricter.
For the series, Reviewed-by: Brian Paul On 08/27/2019 04:57 AM, Jose Fonseca wrote: Uses some of the same -Werror options used by Meson, as suggested by Michel Daezer. --- scons/gallium.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scons/gallium.py b/scons/gallium.py index 21197c8d0d1..2eff4174257 100755 --- a/scons/gallium.py +++ b/scons/gallium.py @@ -473,7 +473,10 @@ def generate(env): '-fmessage-length=0', # be nice to Eclipse ] cflags += [ -'-Wmissing-prototypes', +'-Werror=implicit-function-declaration', +'-Werror=missing-prototypes', +'-Werror=return-type', +'-Werror=incompatible-pointer-types', '-std=gnu99', ] if icc: ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
