This seems perfectly fine to me. For what it's worth:
Reviewed-by: Dylan Baker
Quoting Matt Turner (2016-02-04 17:48:00)
> The next patch adds an algebraic rule that uses the constant 0xff00ff00.
>
> Without this change, the build fails with
>
>return
On Thursday, February 4, 2016 5:48:00 PM PST Matt Turner wrote:
> The next patch adds an algebraic rule that uses the constant 0xff00ff00.
>
> Without this change, the build fails with
>
>return hex(struct.unpack('I', struct.pack('i', self.value))[0])
>struct.error: 'i' format requires
On Monday, February 8, 2016 4:01:37 PM PST Ian Romanick wrote:
> On 02/08/2016 01:59 PM, Kenneth Graunke wrote:
> > On Thursday, February 4, 2016 5:48:00 PM PST Matt Turner wrote:
> >> The next patch adds an algebraic rule that uses the constant 0xff00ff00.
> >>
> >> Without this change, the build
On 02/08/2016 01:59 PM, Kenneth Graunke wrote:
> On Thursday, February 4, 2016 5:48:00 PM PST Matt Turner wrote:
>> The next patch adds an algebraic rule that uses the constant 0xff00ff00.
>>
>> Without this change, the build fails with
>>
>>return hex(struct.unpack('I', struct.pack('i',